Repository navigation
Conversation
szymonrybczak
requested review from
kelset,
lucasbento and
pvinis
as code owners
April 25, 2024 10:55
Contributor
Author
|
I'm wondering should also add this comment to line added inside |
lucasbento
approved these changes
Apr 25, 2024
lucasbento
left a comment
lucasbento
left a comment
Member
There was a problem hiding this comment.
Nice work, thank you for doing this!
Member
Given |
pvinis
reviewed
Apr 25, 2024
| const release: ReleaseT = { | ||
| usefulContent: { | ||
| description: | ||
| 'React Native 0.74 includes Yoga 3.0, Bridgeless by default under the New Architecture, batched onLayout updates, Yarn 3, removal of previously deprecated PropTypes, and some breaking changes, including updates to PushNotificationIOS. The Android Minimum SDK is now 23 (Android 6.0).', |
| }, | ||
| comments: [ | ||
| { | ||
| fileName: '.yarnrc', |
cortinico
approved these changes
Apr 25, 2024
szymonrybczak
force-pushed
the
fix/74/add-proper-info-about-yarn-3
branch
from
April 25, 2024 13:45
4114d5d to
6233994
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For new project created with React Native Community CLI, we'll try to bump Yarn version to
3.6.4which is the supported and maintained one. For people that are upgrading apps in my opinion it's very important to say what this diff means, and how they should handle it inside exciting projects.Builds on top of: react-native-community/rn-diff-purge#75
Test Plan
Get diff from this PR react-native-community/rn-diff-purge#75 and check if the comment is shown properly in right place.
Checklist
README.md(if needed)