Upcoming v0.63.5 cherrypicks discussion

[kelset]

Conversations on this thread are limited to 0.63 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.63.4 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

---

Note: we don't know yet if we will work on a 0.63.5 release, it's basically based on how things shape up with 0.64.

---

Update: it's unlikely we'll do a 0.63 patch, but in case here's the list of commits requested/wanted/needed:

• facebook/react-native@fdcacd7
• facebook/react-native@42dde12
• facebook/react-native@3399896
• facebook/react-native@0e9296b

Stretch goals:

• Fix cannot working Modal's onDismiss facebook/react-native#30688

[grabbou]

When facebook/react-native#30543 lands, we will need to cherry-pick it to this branch too. It is affecting users on older React Native versions as well that upgraded to latest Xcode.

Edit: there it is: facebook/react-native@fdcacd7

[grabbou]

I am going to cherry-pick the aforementioned commit and test whether it fixes the issue on this branch as well, as a part of my testing of the same commit for the 0.64 branch!

[grabbou]

This should also be cherry-picked facebook/react-native#30592 to avoid adding a whole new post install hook to a Podfile.

[retyui]

Really wait for these changes facebook/react-native@b7b0e23

To have an opportunity to get tap location on the <TextInput/> component

[kelset]

@retyui that commit adds new functionality so it's not a candidate for a patch release.

[sandfox]

Could we backport in facebook/react-native@d85d5d2 from facebook/react-native#29882
It's a fix for Modal onDismiss behaviour. It's already in 0.64

[kelset]

@sandfox I've already attempted cherry-picking it during the last round, but it's really complicated because the files involved changed a lot - so it's not achievable. The only option would be for someone to do a PR against the 0.63 branch with the fix "repurposed" to work on it.

[sandfox]

@kelset I'll see if I can do that then: facebook/react-native#30688
So far it's working properly on our internal test case

[priteshrnandgaonkar]

Just a reminder, please use the latest Flipper pod, as we have solved the issues related to Apple M1 machines and arm compatibilities. Latest Flipper pod is 0.75.1

[mrousavy]

@priteshrnandgaonkar a bit off-topic, but does the latest Flipper pod also fix facebook/react-native#30836?

[kelset]

@mrousavy from the comments in the issue seems like it did. In my experience, you can just change your podfile to

use_flipper!('Flipper' => '0.75.1')

To change the Flipper version

[kelset]

potential cherry pick: facebook/react-native@3399896

[retyui]

p.s. @kelset seem you recommend a legacy ruby syntax

-use_flipper!('Flipper' => '0.75.1')
+use_flipper!({ 'Flipper' => '0.75.1' })