feat: support autolinking in monorepos

docs/autolinking.md

@@ -36,28 +36,6 @@ The implementation ensures that a library is imported only once. If you need to
 
 See example usage in React Native template's [Podfile](https://github.com/facebook/react-native/blob/0.60-stable/template/ios/Podfile).
 
-### Custom root (monorepos)
-
-The project root is where `node_modules` with `react-native` is. Autolinking script assume your project root to be `".."`, relative to `ios` directory. If you're in a project with custom structure, like this:
-
-```
-root/
-  node_modules
-  example/
-    ios/
-```
-
-you'll need to set a custom root. Pass it as an argument to `use_native_modules!` function inside the targets and adjust the relatively required `native_modules` path accordingly:
-
-```rb
-# example/ios/Podfile
-require_relative '../../node_modules/@react-native-community/cli-platform-ios/native_modules'
-target 'RNapp' do
-  # React pods and custom pods here...
-  use_native_modules!("../..")
-end
-```
-
 ## Platform Android
 
 The [native_modules.gradle](https://github.com/react-native-community/cli/blob/master/packages/platform-android/native_modules.gradle) script is included in your project's `settings.gradle` and `app/build.gradle` files and:

packages/cli/package.json

@@ -40,6 +40,7 @@
     "envinfo": "^7.1.0",
     "errorhandler": "^1.5.0",
     "execa": "^1.0.0",
+    "find-up": "^4.1.0",
     "fs-extra": "^7.0.1",
     "glob": "^7.1.1",
     "graceful-fs": "^4.1.3",
@@ -69,8 +70,8 @@
   },
   "devDependencies": {
     "@types/command-exists": "^1.2.0",
-    "@types/graceful-fs": "^4.1.3",
     "@types/cosmiconfig": "^5.0.3",
+    "@types/graceful-fs": "^4.1.3",
     "@types/hapi__joi": "^15.0.4",
     "@types/minimist": "^1.2.0",
     "@types/mkdirp": "^0.5.2",

packages/cli/src/tools/config/__tests__/findProjectRoot-test.ts

@@ -0,0 +1,36 @@
+import path from 'path';
+import findProjectRoot from '../findProjectRoot';
+import {
+  cleanup,
+  writeFiles,
+  getTempDirectory,
+} from '../../../../../../jest/helpers';
+
+beforeEach(() => {
+  cleanup(DIR);
+  jest.resetModules();
+});
+
+afterEach(() => cleanup(DIR));
+
+const DIR = getTempDirectory('find_project_root_test');
+
+test('resolves to correct project root', () => {
+  writeFiles(DIR, {
+    'package.json': '{}',
+    'ios/Podfile': '',
+  });
+  const cwd = path.join(DIR, 'ios');
+  expect(findProjectRoot(cwd)).toBe(DIR);
+  expect(findProjectRoot(DIR)).toBe(DIR);
+});
+
+test('resolves to correct project root in a monorepo', () => {
+  writeFiles(DIR, {
+    'package.json': '{}',
+    'packages/mobile/package.json': '{}',
+    'packages/mobile/ios/Podfile': '',
+  });
+  const cwd = path.join(DIR, 'packages/mobile/ios');
+  expect(findProjectRoot(cwd)).toBe(path.join(DIR, 'packages/mobile'));
+});

packages/cli/src/tools/config/findProjectRoot.ts

@@ -0,0 +1,26 @@
+import findUp from 'find-up';
+import path from 'path';
+import {CLIError} from '@react-native-community/cli-tools';
+
+/**
+ * Finds project root by looking for a closest `package.json`.
+ */
+export default function findProjectRoot(cwd = process.cwd()): string {
+  const packageLocation = findUp.sync('package.json', {cwd});
+
+  /**
+   * It is possible that `package.json` doesn't exist
+   * in the tree. In that case, we want to throw an error.
+   *
+   * When executing via `npx`, this will never happen as `npm`
+   * requires that file to be present in order to run.
+   */
+  if (!packageLocation) {
+    throw new CLIError(`
+      We couldn't find a package.json in your project. 
+      Are you sure you are running it inside a React Native project?
+    `);
+  }
+
+  return path.dirname(packageLocation);
+}

packages/cli/src/tools/config/index.ts

@@ -11,6 +11,7 @@ import {logger, inlineString} from '@react-native-community/cli-tools';
 import * as ios from '@react-native-community/cli-platform-ios';
 import * as android from '@react-native-community/cli-platform-android';
 import findDependencies from './findDependencies';
+import findProjectRoot from './findProjectRoot';
 import resolveReactNativePath from './resolveReactNativePath';
 import findAssets from './findAssets';
 import {
@@ -61,7 +62,7 @@ function getDependencyConfig(
 /**
  * Loads CLI configuration
  */
-function loadConfig(projectRoot: string = process.cwd()): Config {
+function loadConfig(projectRoot: string = findProjectRoot()): Config {
   let lazyProject: ProjectConfig;
   const userConfig = readConfigFromDisk(projectRoot);
 

packages/platform-ios/native_modules.rb

@@ -5,24 +5,22 @@
 #
 require 'pathname'
 
-def use_native_modules!(root = "..", config = nil)
+def use_native_modules!(config = nil)
   if (!config)
     json = []
 
-    # Make sure `react-native config` is ran from your project root
-    Dir.chdir(root) do
-      IO.popen("./node_modules/.bin/react-native config") do |data|
-        while line = data.gets
-          json << line
-        end
+    IO.popen("npx react-native config") do |data|
+      while line = data.gets
+        json << line
       end
     end
 
     config = JSON.parse(json.join("\n"))
   end
 
+  project_root = Pathname.new(config["project"]["ios"]["sourceDir"])
+
   packages = config["dependencies"]
-  config_root = config["root"]
   found_pods = []
 
   packages.each do |package_name, package|
@@ -57,10 +55,10 @@ def use_native_modules!(root = "..", config = nil)
     end
 
     podspec_dir_path = Pathname.new(File.dirname(podspec_path))
-    project_root = Pathname.new(config_root)
+
     relative_path = podspec_dir_path.relative_path_from project_root
 
-    pod spec.name, :path => File.join(root, relative_path)
+    pod spec.name, :path => relative_path.to_path
 
     if package_config["scriptPhases"]
       # Can be either an object, or an array of objects
@@ -129,7 +127,6 @@ def pluralize(count)
         "execution_position" => "before_compile",
         "input" => "string"
       }
-
       @ios_package = ios_package = {
         "root" => "/root/app/node_modules/react",
         "platforms" => {
@@ -148,8 +145,13 @@ def pluralize(count)
           },
         }
       }
+      @project = {
+        "ios" => {
+          "sourceDir" => "/root/app/ios"
+        }
+      }
       @config = {
-        "root" => "/root/app",
+        "project" => @project,
         "dependencies" => {
           "ios-dep" => @ios_package,
           "android-dep" => @android_package
@@ -166,8 +168,8 @@ def pluralize(count)
 
       spec.singleton_class.send(:define_method, :name) { "ios-dep" }
 
-      podfile.singleton_class.send(:define_method, :use_native_modules) do |path, config|
-        use_native_modules!('..', config)
+      podfile.singleton_class.send(:define_method, :use_native_modules) do |config|
+        use_native_modules!(config)
       end
 
       Pod::Specification.singleton_class.send(:define_method, :from_file) do |podspec_path|
@@ -197,7 +199,7 @@ def pluralize(count)
     end
 
     it "activates iOS pods" do
-      @podfile.use_native_modules('..', @config)
+      @podfile.use_native_modules(@config)
       @activated_pods.must_equal [{
         name: "ios-dep",
         options: { path: "../node_modules/react" }
@@ -208,23 +210,23 @@ def pluralize(count)
       activated_pod = Object.new
       activated_pod.singleton_class.send(:define_method, :name) { "ios-dep" }
       @current_target_definition_dependencies << activated_pod
-      @podfile.use_native_modules('..', @config)
+      @podfile.use_native_modules(@config)
       @activated_pods.must_equal []
     end
 
     it "does not activate pods whose root spec were already activated previously (by the user in their Podfile)" do
       activated_pod = Object.new
       activated_pod.singleton_class.send(:define_method, :name) { "ios-dep/foo/bar" }
       @current_target_definition_dependencies << activated_pod
-      @podfile.use_native_modules('..', @config)
+      @podfile.use_native_modules(@config)
       @activated_pods.must_equal []
     end
 
     it "prints out the native module pods that were found" do
-      @podfile.use_native_modules('..', { "root" => "/root/app", "dependencies" => {} })
-      @podfile.use_native_modules('..', { "root" => "/root/app", "dependencies" => { "pkg-1" => @ios_package }})
-      @podfile.use_native_modules('..', {
-        "root" => "/root/app", "dependencies" => { "pkg-1" => @ios_package, "pkg-2" => @ios_package }
+      @podfile.use_native_modules({ "project" => @project, "dependencies" => {} })
+      @podfile.use_native_modules({ "project" => @project, "dependencies" => { "pkg-1" => @ios_package }})
+      @podfile.use_native_modules({
+        "project" => @project, "dependencies" => { "pkg-1" => @ios_package, "pkg-2" => @ios_package }
       })
       @printed_messages.must_equal [
         "Detected React Native module pod for ios-dep",
@@ -235,7 +237,7 @@ def pluralize(count)
     describe "concerning script_phases" do
       it "uses the options directly" do
         @config["dependencies"]["ios-dep"]["platforms"]["ios"]["scriptPhases"] = [@script_phase]
-        @podfile.use_native_modules('..', @config)
+        @podfile.use_native_modules(@config)
         @added_scripts.must_equal [{
           :script => "123",
           :name => "My Name",
@@ -253,7 +255,7 @@ def pluralize(count)
         file_read_mock.expect(:call, "contents from file", [File.join(@ios_package["root"], "some_shell_script.sh")])
 
         File.stub(:read, file_read_mock) do
-          @podfile.use_native_modules('..', @config)
+          @podfile.use_native_modules(@config)
         end
 
         @added_scripts.must_equal [{