Doctor could check for DEAD_CODE_STRIPPING=NO and warn users of possible build failures

[mikehardy]

Describe the Feature

Flipper and hermes when enabled on iOS can apparently cause a duplicate symbol problem for current versions in use by react-native.

Not sure what the underlying issue is, if it is fixed, and if it is fixed what version ranges the warning should be restricted to, but the basic test is:

• scan pbxproj.proj and see if DEAD_CODE_STRIPPING is set to NO, if it is, warn the user of

Possible Implementations

Unsure, not sure if doctor is looking inside iOS projects yet, a simple text scan of the file seems sufficient though

Related Issues

react/react-native#32016
This was also noted here facebook/flipper#3117 (comment)

[mikehardy]

This one is definitely needed for catalyst builds,

• if SUPPORTS_MACCATALYST is YES
• and use_flipper is on in the podfile
• then DEAD_CODE_STRIPPING must be YES or your build will break

[github-actions]

There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

[szymonrybczak]

hey @mikehardy do you still this issue is still valid? happy to implement it 😅

[mikehardy]

Hey @szymonrybczak 👋 well...flipper is out right? so I'm not sure this has value as it was a collision between the same symbol in flipper and hermes, but if only one of them is ever in play, I don't think this can happen

I'm going to close it