Revert "fix: click on shadowDOM popup should not close it"

[zombieJ]

Reverts #480

Summary by CodeRabbit

• Bug Fixes

  • 改进了事件目标检查逻辑，确保在相关容器或弹出元素内的事件处理更加准确。

• Refactor

  • 简化了事件目标检查的实现，提高了代码的可读性和效率。

• Tests

  • 移除了与 Popup.Shadow 组件相关的测试，可能表示测试策略的调整或组件行为的重大修改。

[coderabbitai]

Walkthrough

该更改主要涉及对 src/index.tsx 中 generateTrigger 函数的重构，简化了事件目标是否在指定容器或相关弹出元素内的逻辑。原有的辅助函数 inContainer 被移除，其逻辑直接集成到 inPopupOrChild 函数中。此外，tests/shadow.test.tsx 中与 Popup.Shadow 组件相关的测试用例被大幅删除，可能表明测试策略的变化或组件的显著修改。

Changes

文件	更改摘要
src/index.tsx	重构 generateTrigger 函数，移除 inContainer 辅助函数，将其逻辑直接集成到 inPopupOrChild 中。
tests/shadow.test.tsx	删除 Popup.Shadow 组件的测试用例，包括整个 describe 块及其相关的测试逻辑。

Possibly related PRs

• fix: click on shadowDOM popup should not close it #480: 此 PR 也涉及 src/index.tsx 中的 inPopupOrChild 函数，关注与 Shadow DOM 相关的弹出行为，直接与主 PR 的修改相关。

Poem

🐰 在代码的草地上，
逻辑如花儿般绽放，
移除冗余，简化行，
测试虽少，心不慌。
兔子欢跳，庆新章！ 🌼

Tip

Announcements

• The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
• We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
• Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2e16e23 and 0c2a46d.

Files selected for processing (2)

• src/index.tsx (1 hunks)
• tests/shadow.test.tsx (1 hunks)

Files skipped from review due to trivial changes (1)

• tests/shadow.test.tsx

Additional comments not posted (1)

src/index.tsx (1)

279-288: 代码修改看起来不错！

将 inContainer 函数的逻辑直接集成到 inPopupOrChild 函数中，简化了代码结构，提高了可读性和效率，同时保持了原有的逻辑检查。这是一个很好的重构。

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (2e16e23) to head (0c2a46d).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/index.tsx	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   97.85%   97.72%   -0.14%     
==========================================
  Files          13       13              
  Lines         793      791       -2     
  Branches      233      238       +5     
==========================================
- Hits          776      773       -3     
- Misses         17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[afc163]

close ant-design/ant-design#50777