Open
Conversation
Mario185
force-pushed
the
feature/RM-9647-optimize-foreignkey-handling
branch
2 times, most recently
from
e416c20 to
f10b0ad
Compare
a-ctor
reviewed
Mar 17, 2026
Contributor
a-ctor
left a comment
a-ctor
left a comment
There was a problem hiding this comment.
Passing over the review to mike
...mainObjects/Persistence/Rdbms/StorageProviderCommands/Factories/BatchedSaveCommandFactory.cs
Outdated
Show resolved
Hide resolved
...mainObjects/Persistence/Rdbms/StorageProviderCommands/Factories/BatchedSaveCommandFactory.cs
Outdated
Show resolved
Hide resolved
...bjects/Persistence/Rdbms/ForeignKeyOptimization/LazyForeignKeyOptimizationProviderWrapper.cs
Outdated
Show resolved
Hide resolved
...ta/DomainObjects/Persistence/Rdbms/ForeignKeyOptimization/IForeignKeyOptimizationProvider.cs
Outdated
Show resolved
Hide resolved
...on/Data/DomainObjects/Persistence/Rdbms/ForeignKeyOptimization/ForeignKeyOptimizationNode.cs
Outdated
Show resolved
Hide resolved
Mario185
force-pushed
the
feature/RM-9647-optimize-foreignkey-handling
branch
from
f10b0ad to
b0f6417
Compare
MichaelKetting
requested changes
Mar 22, 2026
Member
MichaelKetting
left a comment
MichaelKetting
left a comment
There was a problem hiding this comment.
First part of the review
Remotion/Data/DomainObjects.UnitTests/Factories/BaseConfiguration.cs
Outdated
Show resolved
Hide resolved
...ts.UnitTests/Persistence/Rdbms/SortingOptimization/TestDomain/AutomaticBreaksCountObjects.cs
Show resolved
Hide resolved
....UnitTests/Persistence/Rdbms/ForeignKeyOptimization/ForeignKeyOptimizationNodeFactoryTest.cs
Outdated
Show resolved
Hide resolved
...bjects.UnitTests/Persistence/Rdbms/SortingOptimization/SortingOptimizationNodeFactoryTest.cs
Show resolved
Hide resolved
...DomainObjects.UnitTests/Persistence/Rdbms/SortingOptimization/SortingOptimizationTestBase.cs
Show resolved
Hide resolved
...bjects/Persistence/Rdbms/ForeignKeyOptimization/LazyForeignKeyOptimizationProviderWrapper.cs
Outdated
Show resolved
Hide resolved
| @@ -1,23 +1,28 @@ | |||
| // SPDX-FileCopyrightText: (c) RUBICON IT GmbH, www.rubicon.eu | |||
| // SPDX-License-Identifier: LGPL-2.1-or-later | |||
| using System; | |||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using Remotion.Data.DomainObjects.DataManagement; | ||
| using Remotion.Data.DomainObjects.Mapping; |
| @@ -0,0 +1,204 @@ | |||
| // SPDX-FileCopyrightText: (c) RUBICON IT GmbH, www.rubicon.eu | |||
| @@ -0,0 +1,149 @@ | |||
| // SPDX-FileCopyrightText: (c) RUBICON IT GmbH, www.rubicon.eu | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.rubicon.eu/browse/RM-9647