fix(Breadcrumb)!: BREAKING CHANGE use composition and remove cloneElement#695
Open
paanSinghCoder wants to merge 1 commit intomainfrom
Open
fix(Breadcrumb)!: BREAKING CHANGE use composition and remove cloneElement#695paanSinghCoder wants to merge 1 commit intomainfrom
paanSinghCoder wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rohanchkrabrty
requested changes
Mar 13, 2026
Contributor
rohanchkrabrty
left a comment
There was a problem hiding this comment.
Let's support render prop using useRender from Base UI, instead of as.
Docs - https://base-ui.com/react/utils/use-render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Migration
as={<NextLink href="/" />}withas={NextLink}and movehref(and other link props) toBreadcrumb.Item, e.g.<Breadcrumb.Item href="/" as={NextLink}>Home</Breadcrumb.Item>.Summary
Changes
<NextLink href="/" />} (React element).as={NextLink}(component reference). Put href and other props on Breadcrumb.Item; they are passed through to the component.<Component ref={ref} className={...} href={href} {...props}>{label}</Component>(no cloneElement). Ref is forwarded to the link or custom component (except in the dropdown path).Current page
<span aria-current="page">instead of a link so the current page is not a clickable link.Link content
<a>Home</a>for simple items. With a leading icon, the existing span structure is kept for layout.Type of Change
How Has This Been Tested?
[Describe the tests that you ran to verify your changes]
Checklist:
Screenshots (if appropriate):
[Add screenshots here]
Related Issues
[Link any related issues here using #issue-number]