Skip to content

increase container memory and shm to 20G#3475

Merged
atumanov merged 2 commits into
ray-project:masterfrom
shaneknapp:increase-container-memory
Dec 5, 2018
Merged

increase container memory and shm to 20G#3475
atumanov merged 2 commits into
ray-project:masterfrom
shaneknapp:increase-container-memory

Conversation

@shaneknapp

Copy link
Copy Markdown
Contributor

What do these changes do?

increase memory allocated to docker containers running on jenkins.

@robertnishihara

Copy link
Copy Markdown
Collaborator

This looks good to me.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9779/
Test FAILed.

@shaneknapp

Copy link
Copy Markdown
Contributor Author

test this please

@atumanov atumanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9781/
Test FAILed.

@shaneknapp

Copy link
Copy Markdown
Contributor Author

test this please

@robertnishihara

Copy link
Copy Markdown
Collaborator

@shaneknapp was the Jenkins build hanging? Our Jenkins tests have gotten a bit flaky recently, so test failures are probably not caused by this PR.

@shaneknapp

Copy link
Copy Markdown
Contributor Author

@robertnishihara -- no, i manually killed that build so that i could start testing my new commit immediately.

@atumanov and i hope that this change will de-flake the builds by allocating more memory to the docker containers.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9782/
Test PASSed.

@pcmoritz

pcmoritz commented Dec 5, 2018

Copy link
Copy Markdown
Contributor

This is amazing 🥇

@robertnishihara

Copy link
Copy Markdown
Collaborator

Wow, nice!

@atumanov atumanov merged commit 7a79b7f into ray-project:master Dec 5, 2018
@atumanov

atumanov commented Dec 5, 2018

Copy link
Copy Markdown
Contributor

continuation of this saga shall continue shortly , but this is a good first step ;)

@shaneknapp

Copy link
Copy Markdown
Contributor Author

@atumanov yep, heh... i'm curious as to whether your master build will pass now.

@shaneknapp shaneknapp deleted the increase-container-memory branch December 5, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants