[Java] Add jvm-parameters in Config.#3065
Conversation
|
@chuxi cc |
|
Test PASSed. |
raulchen
left a comment
raulchen
left a comment
There was a problem hiding this comment.
Thanks, I left 2 small comments.
| if (config.hasPath("ray.jvm-parameters")) { | ||
| jvmParameters = config.getStringList("ray.jvm-parameters"); | ||
| } else { | ||
| jvmParameters = null; |
There was a problem hiding this comment.
Use empty list (ImmutableList.of())
| // custom classpath | ||
| classpath = config.getStringList("ray.classpath"); | ||
| // custom worker jvm parameters | ||
| if (config.hasPath("ray.jvm-parameters")) { |
There was a problem hiding this comment.
better rename it to ray.worker.jvm-parameters.
|
@raulchen Addressed |
raulchen
left a comment
raulchen
left a comment
There was a problem hiding this comment.
LGTM. will merge when CI passes
|
Test FAILed. |
|
@AmplabJenkins retest this, please. |
|
Test PASSed. |
4 participants
What do these changes do?
We couldn't specify the system properties for a Java worker now. If we want to do this, we must write the
ray.confin worker classpathes. Obviously, it's not convenient.This PR add a
jvm-parametersitem in config that we can specify the system properties for a Java worker.Related issue number
This fixed the 2nd point in the issue #3062 :
can not set worker jvm parameters in config file.