Skip to content

[cmake] bugfix: rerun build.sh will cause pyarrow files missing#3047

Merged
pcmoritz merged 1 commit into
ray-project:masterfrom
antgroup:cmake-update-v4
Oct 12, 2018
Merged

[cmake] bugfix: rerun build.sh will cause pyarrow files missing#3047
pcmoritz merged 1 commit into
ray-project:masterfrom
antgroup:cmake-update-v4

Conversation

@chuxi

@chuxi chuxi commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

What do these changes do?

  1. move make clean before cmake command, because cmake will build some modules by checking some directories exist or not
  2. avoid always running mvn install plasma java lib

question: do we have better solution of skipping build of some modules? including pyarrow, plasma_java.

Related issue number

@chuxi

chuxi commented Oct 11, 2018

Copy link
Copy Markdown
Contributor Author

cc @robertnishihara @pcmoritz

@AmplabJenkins

Copy link
Copy Markdown

Merged build finished. Test FAILed.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8596/
Test FAILed.

@guoyuhong

Copy link
Copy Markdown
Contributor

@AmplabJenkins retest this, please.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8597/
Test PASSed.

Comment thread build.sh

pushd "$BUILD_DIR"

# avoid the command failed and exits

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which kinds of failures can happen here? Previously there was no || true necessary here, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the script will exit if error happen as set -e at the begin.

So the first time, make clean in an empty directory which leads to makefile not found error.

|| true will redirect the error and keep the script to continue.

I use some directories existence to justify whether the lib is built already. once make clean is called, the directories will be removed.

However, if I call cmake command first, then cmake will see the directories exist. And it will not build the libs any more. Then I can make clean, which leads to the directories removed. So the error happens.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

@pcmoritz pcmoritz merged commit 87639b9 into ray-project:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants