[cmake] bugfix: rerun build.sh will cause pyarrow files missing#3047
Conversation
…l plasma java lib
|
Merged build finished. Test FAILed. |
|
Test FAILed. |
|
@AmplabJenkins retest this, please. |
|
Test PASSed. |
|
|
||
| pushd "$BUILD_DIR" | ||
|
|
||
| # avoid the command failed and exits |
There was a problem hiding this comment.
Which kinds of failures can happen here? Previously there was no || true necessary here, right?
There was a problem hiding this comment.
the script will exit if error happen as set -e at the begin.
So the first time, make clean in an empty directory which leads to makefile not found error.
|| true will redirect the error and keep the script to continue.
I use some directories existence to justify whether the lib is built already. once make clean is called, the directories will be removed.
However, if I call cmake command first, then cmake will see the directories exist. And it will not build the libs any more. Then I can make clean, which leads to the directories removed. So the error happens.
There was a problem hiding this comment.
Thanks for the explanation!
What do these changes do?
question: do we have better solution of skipping build of some modules? including pyarrow, plasma_java.
Related issue number