[java] fix a bug that cache result isn't set in FunctionManager#3000
Merged
robertnishihara merged 1 commit intoOct 3, 2018
Merged
Conversation
raulchen
changed the title
Contributor
|
tks. |
|
Test PASSed. |
raulchen
approved these changes
Sep 30, 2018
raulchen
left a comment
raulchen
left a comment
Contributor
There was a problem hiding this comment.
LGTM, will merge when CI passes.
Contributor
|
@robertnishihara |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
before fix,RAY_FUN_CACHE use only get method ,can only get null, LambdaUtils.getSerializedLambda will always run
fix : put in RAY_FUN_CACHE after create FunctionDescriptor ,LambdaUtils.getSerializedLambda will only run if can't get from cache
Related issue number
not that i know of