Repository navigation
ggml-openvino : fix 2D/3D view input shape inference - #303
Draft
mostafafaheem wants to merge 1 commit into
Draft
mostafafaheem wants to merge 1 commit into
mostafafaheem wants to merge 1 commit into
Conversation
Collaborator
Author
|
@cavusmustafa @wine99 @zhaixuejun1993 Interested to know what you think about this. Side note: I was tempted to do some more changes in this PR that I found already were done in #240. It would be nice if that PR was merged after rebasing and resolving conflicts. I'd be happy to take that on if you want. |
mostafafaheem
marked this pull request as draft
August 27, 2026 19:16
Collaborator
Author
|
Converted to draft until end-to-end execution on Gemma 4 MMProj (model where this issue was encoutered) is correct. |
wine99
force-pushed
the
dev_backend_openvino
branch
from
August 28, 2026 01:36
01d5a57 to
40d3fdd
Compare
mostafafaheem
force-pushed
the
unsqueeze_before_view
branch
from
August 28, 2026 16:19
7941508 to
e055c16
Compare
ravi9
force-pushed
the
dev_backend_openvino
branch
2 times, most recently
from
September 3, 2026 21:10
fd9bc04 to
33237ab
Compare
mostafafaheem
force-pushed
the
unsqueeze_before_view
branch
from
September 10, 2026 14:07
e055c16 to
749b716
Compare
ravi9
force-pushed
the
dev_backend_openvino
branch
from
September 14, 2026 17:49
37b4e1d to
926ef68
Compare
mostafafaheem
force-pushed
the
unsqueeze_before_view
branch
2 times, most recently
from
September 16, 2026 06:31
37b9a91 to
a8ec243
Compare
wine99
force-pushed
the
dev_backend_openvino
branch
from
September 16, 2026 08:07
0365b00 to
37b53fd
Compare
mostafafaheem
force-pushed
the
unsqueeze_before_view
branch
from
September 16, 2026 17:17
a8ec243 to
dcf3b38
Compare
ravi9
force-pushed
the
dev_backend_openvino
branch
from
September 17, 2026 17:37
40a2a96 to
972d231
Compare
mostafafaheem
force-pushed
the
unsqueeze_before_view
branch
from
September 30, 2026 01:22
dcf3b38 to
7e40846
Compare
ravi9
force-pushed
the
dev_backend_openvino
branch
2 times, most recently
from
September 30, 2026 22:54
6b08f8a to
ab07546
Compare
mostafafaheem
force-pushed
the
unsqueeze_before_view
branch
from
October 1, 2026 12:17
7e40846 to
2386665
Compare
ravi9
force-pushed
the
dev_backend_openvino
branch
4 times, most recently
from
October 3, 2026 19:48
308ccd8 to
836d571
Compare
mostafafaheem
force-pushed
the
unsqueeze_before_view
branch
from
October 8, 2026 02:33
2da40d7 to
d943707
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
process_view_input_newutil. This PR introduces anUnsqueezeto 4D in order to avoid this issue.Additional information
Requirements
ifblock