Skip to content

Default uart fixups - #3185

Open
will-v-pi wants to merge 4 commits into
developfrom
default-uart-fixups
Open

will-v-pi wants to merge 4 commits into
developfrom
default-uart-fixups

Conversation

@will-v-pi

Copy link
Copy Markdown
Contributor

Add UART_CLK_DEST_PERI() and UART_CLK_DEST_SYS() macros to use in low power

Document the pairing between stdio/stdout/stdin init/deinit functions

Fix and simplify the PICO_DEFAULT_UART_TX_PIN/RX_PIN checks

Fixes #3172 and #3173

@will-v-pi will-v-pi added this to the 2.3.2 milestone Sep 7, 2026
@will-v-pi
will-v-pi requested a review from kilograham September 7, 2026 09:35
Co-authored-by: Andrew Scheller <lurch@durge.org>
Co-authored-by: will-v-pi <108662275+will-v-pi@users.noreply.github.com>
@lurch

lurch commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

I guess either this PR or #3280 will need to be updated, based on which PR gets merged first?

@will-v-pi

Copy link
Copy Markdown
Contributor Author

I guess either this PR or #3280 will need to be updated, based on which PR gets merged first?

That PR looks unrelated? This change is in UART and a small bit of low power, but that change is adding functions to hardware_gpio?

@lurch

lurch commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

That PR looks unrelated? This change is in UART and a small bit of low power, but that change is adding functions to hardware_gpio?

Oh bother, I linked to the wrong PR-number - I meant #3284 🤦

I've not looked in detail at #3284 yet, but I was assuming that after it was merged you'd be able to set PICO_DEFAULT_UART_RX_PIN to one of the QSPI pins, and so therefore the PICO_DEFAULT_UART_RX_PIN >= NUM_BANK0_GPIOS part of this PR would need tweaking? (But perhaps I've misunderstood)

@will-v-pi

Copy link
Copy Markdown
Contributor Author

Oh yes, in that case I think I'll revert that check here, rather than adding more complexity so it works with QSPI GPIOs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants