Skip to content

Add zizmor to all RAPIDS projects and address all warnings #275

Description

@gforsyth

Recent security scans turned up a few potential security holes in our CI configuration -- while most of them were likely not actually exploitable, it doesn't hurt to tighten things up.

We should have zizmor installed as a pre-commit hook on all the RAPIDS repos, so that changes to workflows get audited by the linter (before a human gets to them).

Some general configuration:

In .github/zizmor.yml, we add the following:

rules:
  unpinned-uses:
    config:
      policies:
        # We require SHA-pinning for all workflows and actions _except_ for those from
        # rapidsai/shared-workflows and rapidsai/shared-actions
        "rapidsai/shared-workflows/*": any
        "rapidsai/shared-actions/*": any
        "*": hash-pin

Which, as noted in the comment, disables the warning for unpinned mutable refs for our shared-workflows, because we understand that risk and the trade-off with the flexibility and centralization it grants us.
For everything else, we selectively silence warnings if they are non-issues with in-line comments, as blanket disable lines are generally not a good idea.

Repos to check and fix

Edit by @jakirkham : Updated the list in the OP with the ones in Gil's comment and a few more found via this search

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions