Skip to content

release v1.18.3 - #475

Merged
ranxianglei merged 2 commits into
masterfrom
2026-09-30_release-v1.18.3
Oct 1, 2026
Merged

ranxianglei merged 2 commits into
masterfrom
2026-09-30_release-v1.18.3

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Auto-fallback from the one-click release workflow: direct push to master was blocked by branch protection. Merging this PR publishes via the standard release.yml flow.

Changes since v1.18.2

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

收到,开始处理这个 release PR。初步核查结论(先报关键发现,完整审计随后):

⚠️ 阻塞项:pr-validation CI 必挂(3 项失败)

本地对 2026-09-30_release-v1.18.3 分支跑 scripts/ci/check-pr.sh 实测:

✓ Branch name matches YYYY-MM-DD_short-title
✗ devlog/2026-09-30_release-v1.18.3/REQ.md is missing
✗ devlog/2026-09-30_release-v1.18.3/WORKLOG.md is missing
✗ Version bumped (1.18.2 → 1.18.3) but no CHANGELOG update found

根因:one-click release workflow(release-manual.yml)的 Bump 步骤只改 package.json + package-lock.json(其 "Verify bump diff" 甚至强制只允许这两个文件),不生成 devlog 和 CHANGELOG 条目——但 pr-checks.yml 的三项检查都要求它们。这是该 workflow 首次走到 fallback 路径(此前 v1.16.0–v1.18.2 均为手工发布、自带 devlog+changelog),所以问题第一次暴露。master 分支保护要求 pr-validation 通过,因此此 PR 当前状态无法合并。

计划:

  1. 直接在 PR 分支补上缺失的 devlog/2026-09-30_release-v1.18.3/{REQ,WORKLOG}.md 和双语 CHANGELOG 的 ### v1.18.3 条目(按既往 release 惯例),解除合并阻塞;
  2. 对 workflow 本身的缺陷(fallback PR 永远缺 devlog/changelog)另立 issue(带来源标记);
  3. 完成 v1.18.2 → v1.18.3 版本区间回归审计(19 个变更逐项过既有行为),最后给结构化七问结论。

…-validation fix-up)

The one-click release workflow only bumps package.json/package-lock.json and its
'Verify bump diff' step enforces exactly those two files, so the fallback PR it
opens always lacks the devlog folder and CHANGELOG entries that pr-checks.yml's
check-pr.sh requires. This fix-up adds them per the standard release convention
(AGENTS.md §5.4.2); no code is touched.

Found during review of PR #475; local run of scripts/ci/check-pr.sh failed 3
checks before this commit, passes all after.
@github-actions

Copy link
Copy Markdown
Contributor Author

📦 Built Plugin Artifact

Branch: 2026-09-30_release-v1.18.3 (4b1e727)

Option A — Install from npm PR tag (recommended)

opencode plugin opencode-acp@pr-475 --global

Each push to this PR publishes a new version under the pr-475 npm tag.

Option B — Install from GitHub

opencode plugin "github:ranxianglei/opencode-acp#2026-09-30_release-v1.18.3" --global

Option C — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf opencode-acp-pr475.tgz
cp -r package/dist ~/.cache/opencode/packages/opencode-acp@latest/node_modules/opencode-acp/dist
  1. Restart opencode to pick up changes.

This comment is automatically updated on each push.

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

PR #475 review 结论 — release v1.18.3

审查范围:PR 自身 diff(纯版本 bump,2 文件)+ v1.18.2 → HEAD 版本区间回归审计(19 个非 merge commit,按 release-PR 审计政策)。CI 全绿:pr-validation / build / test(22) / test(24) / e2e / build-artifact ✅,mergeable_state: clean。

① 是什么问题
标准发布请求——把 v1.18.2 以来已合入 master 的修复以 npm v1.18.3 发布。审查中发现的真问题:one-click workflow 的 fallback 路径产出了一个不完整的 release 分支(缺 devlog + CHANGELOG),被本项目自己的 pr-validation 门拦死。

② 什么原因导致的(两层)

  • 表面层:分支只有 package.json/lockfile 版本行,缺 devlog/2026-09-30_release-v1.18.3/{REQ,WORKLOG}.md 和双语 changelog 条目 → 本地实测 check-pr.sh 3 项失败 → 分支保护下无法合并。
  • 根因:release-manual.yml 的 Bump 步骤只改两个文件(其 "Verify bump diff" 甚至强制这个 allowlist),从不生成 devlog/changelog;而它的 step summary 声称 "with the generated changelog" —— 意图与实现不符。这是该 workflow 首次走到 fallback 路径(v1.16.0–v1.18.2 均为手工发布、自带 devlog+changelog),缺口因此首次暴露。

③ 怎么修复的
PR 分支上补 fix-up commit 4b1e7275:devlog 文件夹 + 双语 CHANGELOG ### v1.18.3 条目(按 §5.4.2 手工发布惯例),零代码改动;本地复测全过,CI pr-validation 通过。workflow 根因本身:#475 是自动立项 issue,按 loop guard 政策我不擅自另立 issue,缺陷详情与修法建议见下方「待你拍板」,由你决定立项与否。

④ 是否有回归问题:本版本引入回归:无。逐项审了每个变更触碰路径的既有行为:

⑤ 是否破坏缓存:不涉及。未触碰 LLM prefix cache 相关路径(prune/inject/tool-cache);#461 仅影响日志去重;#405 每次动作新增两次 env 读取,开销可忽略。

⑥ 是否改了设计方向:无架构转向。#405 是把既有「向 billion-context 让位」机制从 launcher-only 扩展到双标记 + action-time 重采样,属同一设计方向内的加固(本仓继续负责 V1,V2 归 billion-context,见 #442)。

⓻ 是否引入新配置:无新用户配置/env/默认值。BILLION_CONTEXT_NATIVE 是 billion-context 自己的标记(ACP 只读不写);MAX_OVERHEAD_ERROR_SESSIONS=1024 是内部常量,非配置键。


⚠️ 待你拍板:one-click workflow fallback 路径缺陷

release-manual.yml 的 fallback 路径今后每次都会产出缺 devlog/changelog 的 PR,每次都要人工补(本次即如此)。修法建议:fallback 路径增加一步生成 devlog/{branch}/REQ+WORKLOG 和双语 changelog 条目(内容可从 "Changes since " 自动生成),并相应放宽 Verify-bump-diff allowlist。你点头我就直接修(或先立项再修)。

操作提示(合并时)

请用标准 Merge 按钮。release.yml 靠 commit 标题识别 release 合并:squash 标题 "release v1.18.3 (#475)" 不匹配 Pattern 2(^release: v... 要求冒号),会静默跳过发布;标准合并标题可正常匹配。

判定

代码与区间审计均通过,阻塞项已修复并验证(CI 6/6 绿)。可以合并——请你本人点击 Merge(§5.1.1.2:agent 不执行合并)。合并后 release.yml 自动打 tag → 构建 → 测试 → 发 npm latest → GitHub Release。

@ranxianglei
ranxianglei merged commit f0502e7 into master Oct 1, 2026
6 checks passed
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

✅ Published opencode-acp@1.18.3 to npm latest tag.

opencode plugin opencode-acp@latest --global

npm | GitHub Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant