Repository navigation
test: fix E2E — add protection scenarios + include 05/06 in CI - #214
Merged
Merged
Conversation
E2E tests had severe gaps that made them ineffective: - ALL protection disabled (preserveRecentMessages:0) — the mechanism fixed 3 times (PR #210/#211/#212) was never exercised - CI ran only 4/6 scenarios (05 subagent, 06 nudge missing) - verify.ts only checked blockCount, not which messages were protected Changes: - run-e2e.sh: per-scenario config override via 'acpConfig' JSON field - verify.ts: compressedCount/min/max checks (byMessageId inspection) - scenario 07: protection-filtered (production config, compress succeeds via soft-filter, protected msgs excluded from compressed set) - scenario 08: nudge-with-protection (nudge→compress with protection enabled — tests exact bug from PR #207/#210/#212) - ci.yml: all 8 scenarios now in CI All 8 scenarios verified locally (8/8 pass).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2E tests had severe gaps that made them ineffective at catching real bugs. This PR fixes them.
Problems Found
preserveRecentMessages: 0) — the mechanism fixed 3 times (PR fix: split protected ranges + soften last-user-message protection #210/release: v1.14.2 — split protected ranges + soften last-user-message #211/fix: soften protected zone — filter instead of reject + reduce default to 5 #212) was completely untestedblockCount, never verified which messages were compressed vs protectedChanges
run-e2e.sh: per-scenario config override viaacpConfigJSON field — scenarios can now test production-like protection settingsverify.ts: addedcompressedCount/minCompressedCount/maxCompressedCount— inspectsbyMessageIdto verify protection actually filtered messagesprotection-filtered— production config (preserveRecentMessages: 5), compress "all", verifies soft-filter (not hard-reject) + protected msgs excludednudge-with-protection— nudge→compress WITH protection enabled — tests exact bug scenario from PR fix: preserve growth baseline when nothingToCompress #207/fix: split protected ranges + soften last-user-message protection #210/fix: soften protected zone — filter instead of reject + reduce default to 5 #212ci.yml: all 8 scenarios now in CI (was 4)Verification