Repository navigation
[PR] fix: register PUT /__bili/external-summary/credential so Web UI "Save Key" works (#3443) - #3445
Closed
ranxianglei wants to merge 2 commits into
Closed
ranxianglei wants to merge 2 commits into
ranxianglei wants to merge 2 commits into
Conversation
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.4057-pr.3445.771633cThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3445.tgz
npm install -g packageInstall instructions are refreshed on each push. |
This was referenced Oct 17, 2026
fix: external summary credentials — readable failures, bounded retry, tri-state status (#3488)
#3541
Merged
Owner
Author
|
(ai: zhipuai-lb/glm-5.3) 陈旧票清理(第三批动作①):目标 issue #3443 已关。为避免重复劳动关闭本 PR;如判断有误请直接 reopen 并留言。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(ai: vllm-qwen/qwen3.8-27b)
Closes #3443
What
The Web UI "Save Key" button sends
PUT /__bili/external-summary/credential, which was never registered on the router → permanent 404 (no such management endpoint). External-summary credentials could only be saved by hand-writing<config>.summary-credentials.json.Root cause (git forensics)
bcf40118d(external summary feature) added the route inline insrc/server.ts.273c83945(refactor: extract the /__bili + /__acp admin route surface intosrc/server/admin.ts, audit: 全仓冗余审计与重构计划——server.ts 解体、客户端矩阵去重、死代码、AGENTS.md 模块图腐化 #1440 P2 cut 1) moved all admin routes out of server.ts.handleSummaryCredentialPutdirectly instead of going through the router, so CI stayed green.Affects master and every release since (including the reporter's 0.1.197).
Changes
src/server/admin.ts— registerPUT /__bili/external-summary/credentialinhandleAdminRoutenext to the config routes; inherits the same loopback + trusted-origin gates as the sibling admin paths (the gates sit above the registration).tests/web-routing.test.ts— regression test through the REAL proxy/router (startServer, port 0): malformed body → 400; save → 200{ok, configured:true}with no key echo and the private store file written;GET /__bili/configreflectssecret:<name>status; delete (key: null) →configured:false. Verified red without change 1 (404) and green with it.src/server.ts— drop the dead web-handler import left by the admin-route extraction (all nine symbols unused; same refactor-debris family). Separate labeled commit.Behavior change (old → new)
PUT /__bili/external-summary/credential: permanently 404 → working endpoint. Security posture UNCHANGED: loopback-source + trusted-origin gated exactly like every other/__bili/*admin path.Verification
npm run typecheckclean.tests/web-routing.test.ts9/9 (incl. the new test),tests/external-summary-settings.test.ts43/43. Full-suite verdict = remote CI on this head.