Repository navigation
test: pin the overflowArmTokens RELEASE direction + restart round-trip (#1129) - #1142
Merged
Merged
Conversation
#1129) The ARMING direction of the one-shot overflow arm was pinned (#554/#1110 tests) but the RELEASE direction rested on three bare `delete session.stats.overflowArmTokens` writes (streaming src/loop/core.ts, non-streaming src/server.ts, plugin src/plugin.ts) with no regression net — a refactor mis-gating any of them would 413 side requests permanently. Adds two e2e pins on the existing side-request rig: - arm -> local 413 -> healthy main turn's REAL usage report retires the arm -> the same oversized-but-fits-declared-window side request FORWARDS again. - restart round-trip: armed session flushAll -> memory cleared -> fresh store over the same dir -> still 413 after loadSync reload -> usage releases -> forwards again. Pin validated by temporarily removing the core.ts delete: exactly these two tests fail (12 pass / 2 fail), restored green (14/14).
Contributor
📦 Built Package ArtifactBranch: Option A — Install from npm PR tag (recommended)npm install -g billion-context@pr-1142Each push to this PR publishes a new version under the Option B — Download artifact
tar xzf billion-context-pr1142.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1129
Context
PR #1111 (side-request guard must not clamp on the host usage baseline) is merged into master, but the follow-up test pins it carried (PR #1132, merged into #1111's branch at
b583bbejust before that branch landed) were stranded:git merge-base --is-ancestor b583bbe origin/masteris false — master got #1111's fix commit without the pin commit. This PR re-lands equivalent pins directly on current master (945a161).What was missing
The ARMING direction of the one-shot overflow arm was already pinned (
#554/#1110tests), but the RELEASE direction rested on three baredelete session.stats.overflowArmTokenswrites — streamingsrc/loop/core.ts, non-streamingsrc/server.ts, pluginsrc/plugin.ts— plus theresetSessionCompressionreset, with no regression net. A refactor mis-gating any of them would 413 side requests permanently: the #1110 deadlock shape re-entered through the overflow path.Pins added (existing side-request rig,
tests/side-request-isolation.test.ts)flushAll()→ memory cleared → freshSessionStoreover the same dir → still 413 after theloadSyncreload path (arm restored from disk) → usage report releases it → forwards again.Pin validation
Temporarily commenting out the
core.tsdelete fails exactly these two tests (12 pass / 2 fail); restored, the file is green 14/14.Gates
Rig change is additive only:
startRigaccepts an optionalstore(default unchanged: disabled store).