feat(apps): align +release commands with new release API format - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The spark
app.releaseOpenAPI was upgraded. This PR aligns theapps +release-*command family with the new format. Response fields remain snake_case at the gateway (the camelCasego.tagvalues in the new IDL are internal thrift tags, not the public wire format — verified against the existingapps +listcommand and existing release unit tests), so no field-casing migration is involved. Three surgical deltas: the create scope, the list page-size documented ceiling, and surfacing the newcommit_idfield.Changes
shortcuts/apps/apps_release_create.go: align+release-createscopespark:app:publish->spark:app:writeshortcuts/apps/apps_release_list.go: raise--page-sizedocumented max from 50 to 500 (server enforces viavt.le:500; default stays 20, no client-side validation added)shortcuts/apps/apps_release_get.go: print acommit_idline in pretty output when non-empty (JSON output already passes it through); placed before the status-conditional online_url/error_logs block, independent of statusshortcuts/apps/apps_release_create_test.go,apps_release_get_test.go: update scope assertion; add present/absent/emptycommit_idrendering testsskills/lark-apps/references/lark-apps-release-list.md,lark-apps-release-get.md: document the page-size 500 ceiling and thecommit_idoutput fieldTest Plan
make unit-testpassed (go test ./shortcuts/apps/...all green)lark-cli apps +release-list --helpshowspage size (max 500);+release-create --app-id app_x --branch foo --dry-runemitsPOST /open-apis/spark/v1/apps/app_x/releaseswith body{"branch":"foo"};+release-get --app-id app_x --release-id 1 --dry-runemits the correct GET pathRelated Issues
N/A