Skip to content

Implement useIssueLinks #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spdiswal merged 4 commits into from
May 3, 2026
Merged

Implement useIssueLinks #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b198576
Fix pluralisation in `useConciseSubjectLines` message
spdiswal Apr 26, 2026
3b529f0
Add unit tests for dependency upgrade commits
spdiswal May 2, 2026
b218d0d
Implement `useIssueLinks`
spdiswal May 3, 2026
4af8bae
Include issue link examples in reports
spdiswal May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/domains/configurations/Configuration.fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export function fakeConfiguration(overrides: ConfigurationTemplate = {}): Config
useConciseSubjectLines: { maxLength: 50 },
useEmptyLineBeforeBodyLines: {},
useImperativeSubjectLines: {},
useIssueLinks: {},
useIssueLinks: { position: "anywhere" },
useLineWrapping: {},
useSignedCommits: {},
...overrides.rules,
Expand Down
13 changes: 10 additions & 3 deletions src/domains/rules/UseConciseSubjectLines.tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,19 @@ describe.each`

describe.each`
subjectLine
${"Bump vite from 4.1.1-beta.0 to 4.3.2"}
${"Upgrade tsgo to 7.0.0-dev.20260131.1"}
${"squash! Downgrade the grumpy cat module from 3.1.4 to 3.0.0"}
${"Pre-release v10.12.22-next"}
${"Pin the Node.js image to 4af617c"}
${'Revert "bugfix"'}
${'Revert "retrieve data from the exclusive third-party service"'}
${'revert "Organise the quarterly chaos into a spreadsheet"'}
${'amend! Revert "retrieve data from the exclusive third-party service"'}
${'Revert "Revert "Revert "Fix the nasty bug from yesterday"""'}
${'fixup! Revert "keep the lowercase story around long enough to exceed the limit"'}
${'fixup! revert "keep the lowercase story around long enough to exceed the limit"'}
${'Revert "Upgrade nginx image digest to 9d739ff1ada6"'}
`(
"when the subject line of $subjectLine contains a revert marker",
"when the subject line of $subjectLine contains a dependency version or a revert marker",
(props: { subjectLine: string }) => {
const commit = fakeCommit({ message: props.subjectLine })

Expand Down
Loading
Loading