Conversation
amogh-jahagirdar
force-pushed
the
scan-plan-model-parser-only-cleanup
branch
from
November 3, 2024 16:31
743c55d to
2d019f5
Compare
amogh-jahagirdar
force-pushed
the
scan-plan-model-parser-only-cleanup
branch
from
November 3, 2024 16:33
2d019f5 to
ae5c475
Compare
amogh-jahagirdar
commented
Nov 3, 2024
| import org.apache.iceberg.expressions.Expression; | ||
| import org.apache.iceberg.expressions.ResidualEvaluator; | ||
|
|
||
| public class UnboundBaseFileScanTask extends BaseFileScanTask { |
Collaborator
Author
There was a problem hiding this comment.
this is important, we should double check we're not making classes unnecessarily public. I cleaned up this case, but let's double check as we iterate.
amogh-jahagirdar
commented
Nov 3, 2024
Comment on lines
+46
to
+47
| response.specsById() != null | ||
| || (response.fileScanTasks() == null || response.fileScanTasks().isEmpty()), |
Collaborator
Author
There was a problem hiding this comment.
I fixed the condition for failing when specs by id is missing as well. We only need to have specs by Id defined when the response has file scan tasks, but it's not needed if there's just plan tasks.
rahil-c
approved these changes
Nov 4, 2024
rahil-c
left a comment
rahil-c
left a comment
Owner
There was a problem hiding this comment.
Thanks @amogh-jahagirdar this looks clean!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.