Skip to content

Queue path parity gaps vs upstream's onSend #105

Description

@radroid

Found during the 2026-08-14 sync seam review; both pre-existing, neither caught by typecheck or tests. handleQueueComposerSubmission in ChatView.tsx returns before upstream's onSend handling of:

  1. parseStandaloneComposerSlashCommand — with legacy plan mode enabled, typing /plan or /default while in queue mode enqueues the literal text as a message instead of switching interaction mode.
  2. expiredTerminalContextCount — upstream toasts when terminal contexts expired between capture and send; the queue path drops them silently (it destructures only sendableTerminalContexts / hasSendableContent from deriveComposerSendState).

Also from the same review, cosmetic decision: queueButton in ComposerPrimaryActions.tsx has no stageBackdropVariant branch, so in artwork identification mode the composer loses the stage treatment whenever Queue is the primary action. Not a revert (Queue is fork-only), just an inconsistency to resolve deliberately.

The enqueue-failure channel half of this review was already fixed in the sync landing (fix(web): surface enqueue failures as a toast, not the maskable error banner).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions