Repository navigation
Conversation
When the URL's hash points inside a closed <details>, Chrome opens it before hashchange fires and animates the open. reveal() saw it as already open and skipped the no-transition switch, so the line was still hidden (content-visibility) when the smooth scroll started, and the page didn't move. reveal() now always turns transitions off for the enclosing disclosures, which also finishes an open in progress. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
raj-portfolio | 5e66902 | Sep 28 2026, 01:07 AM |
Found while checking production after #20.
Bug. With the page already open, changing the hash to a resume line did nothing when smooth motion is on. That covers pasting
curlycloud.dev/#r-…into the address bar and going back or forward between hashes. The line's role opened, but the page stayed where it was. Fresh loads, citations, stars and "source:" links go throughfocusAnchordirectly and weren't affected. Reduced motion and Saver weren't affected either.Cause. For a hash inside a closed
<details>, Chrome opens it beforehashchangefires and runs the open animation.reveal()saw the<details>as already open, so it skipped turning transitions off. The content was stillcontent-visibility: hiddenmid-animation, soscrollIntoViewhad nothing to scroll to.Fix.
reveal()now always setsdata-jumpfor the enclosing disclosures. That also finishes an open that is already running.Checked on
bun run preview, motion High:#r-…lines lands the line on screen. On production today it doesn't.bun run typecheckis clean;bun run testhas 748 passing.🤖 Generated with Claude Code