Repository navigation
Conversation
rabesss
force-pushed
the
dot/fix-254-event-strings
branch
from
October 6, 2026 14:29
c96a188 to
ed073cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #254.
Scrub decoded JSON strings and keys at the event serialization boundary, after standard JSON marshaling. Covers nested artifacts, maps, typed Details and custom marshalers without mutating caller-owned data or changing numeric precision, benign JSON bytes, or serialization/terminal error behavior. Documents the boundary; no shared secrets-parser changes.
Validation
-buildvcs=falsepassFull
go test ./...was attempted and retains the clean-main sandbox failures: network-dependent client tests and nine player AF_UNIX socket tests. Worktree builds require-buildvcs=falsebecause of the environment's VCS lookup. Hosted CI and Security passed on the final head: https://github.com/rabesss/impartus-cli/actions/runs/37479466827. The latest title check also passes.