Repository navigation
Conversation
rabesss
force-pushed
the
dot/fix-258-range-union
branch
from
October 6, 2026 14:29
df9b66e to
492cac9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #258.
Extend an overlapping credential span through the full union rather than dropping its tail. Preserve contained, disjoint and adjacent-span behavior.
Validation
-buildvcs=falsepassFull
go test ./...was attempted. The unchanged baseline fails network-dependent client tests and nine player tests because this cloud sandbox cannot resolve example.com or bind AF_UNIX sockets. Worktree builds require-buildvcs=falsedue to the environment's VCS lookup. Hosted CI and Security passed on the final head: https://github.com/rabesss/impartus-cli/actions/runs/37479404062. The latest title check also passes.This does not address the separate plain-text escaped-quote issue #257.