Repository navigation
fix(web): floating portrait previews no longer crash beside the details card - #43
Merged
Merged
Conversation
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks upstream pingdotgg#14968 (fixes pingdotgg#14959), which is not merged upstream yet.
0.0.57-v2 crashes with React pingdotgg#185 when a preview floats beside the inline thread details card at some window widths. The card was placed beside a chat lane solved with the card as an obstacle, so each report moved the lane and resized the card, and the two states alternated forever. The card is now placed beside the lane computed without it.
Checked with a sweep of about 70k canvas, preview, and interaction combinations replaying both layout effects, including the card's measurement reset: every case settles, and the settled card never covers the drawn chat lane.