feat(mainnet): include all benchmarks#478
Conversation
ec2ffde to
1c65204
Compare
peterwht
left a comment
There was a problem hiding this comment.
Incredibly clean PR. I've got no concerns. Will wait to approve until after XCM is merged
Daanvdplas
left a comment
There was a problem hiding this comment.
The weight results are a little bit concerning to me as there are many differences when comparing it to asset hub or the other project that we work on. Also, have you thought about putting the weight functions we use for the runtimes in a common folder?
|
I've re-excetued the benchmarks now and using a configuration with more steps and repetitions. I can see complexity parameters being included in the results now. cc @Daanvdplas Although, I can still see some divergence between the #read/writes in these results and what we have seen in other places. I believe some related to balances are influenced by the existence of MaintenanceAccount. |
437de12 to
fd64662
Compare
refactor(benchmark): reorg files
* feat(benchmark): add pallet_xcm extrinsic benchmarks * refactor(benchmkars): amend xcm transfer_assets benchmark fmt * style(benchmarks): pretty comments. * refactor(benchmarks): fund SA of AH on pop in reserve_transfer benchmark * feat(mainnet): add generic & fungible xcm benchmarks * refactor(benchmarks): don't define CheckAccount for pallet_xcm_benchmarks::fungible * refactor(benchmarks): amend benchmarks for pallet_xcm_benchmarks::generic::unsubscribe_version * feat(mainnet): configure xcm Weigher as WeightInfoBounds * docs(xcm): missing doc * refactor(weights): MAX_ASSETS is MaxAssetsIntoHolding * refactor(mainnet): remove default weights from queue pallets * docs(xcm): credit source for WeighAssets impl * docs(xcm): reminders for updating benchmarks * refactor(mainnet): DeliveryHelper considers delivery to parent * docs(benchmarks): clarify xcm NonFungible AllOf weight comments * refactor(api): reorg imports * style(benchmark): refactor import syntax * docs(bencmark): better docs for XcmBalances * refactor(benchmark): define locations via xcm config definitions * test(xcm): ensure xcm encoding size * refactor(benchmark): improve worst_case_response * chore(benchmark): update results for query_response bench * style(benchmarks): remove RelayAsset * docs(benchmarks): explain ExistentialDepositAsset * docs(xcm): note worst_case_holding needs updating * style(benchmark): better naming * chore(benchmarks): update xcm benchmarks visibility * test(xcm): amend router_uses_ump_for_relay_and_xcmp_for_para * test(xcm): amend router_uses_ump_for_relay_and_xcmp_for_para * refactor(benchmarks): unnecessary ParaId::from * refactor(xcm): unnecessary u64 cast * test(xcm): msg_length factor is > 1 in price_for_parent_delivery~
3eff2d3 to
c9aa96b
Compare
Adds to mainnet runtime benchmarks for all pallets.
Depends on:
On introducing the benchmarks, these are also refactored into
pop_runtime_common, such that they can be used from any of the runtimes. This refactor is pushed in: da0aedfCloses: #435
[sc-2757]