Skip to content

deps: pin published sdk-go/v2 in the Go verify modules (qfg-ao5h4) - #37

Merged
jdwyah merged 1 commit into
mainfrom
qfg-ao5h4-go-verify-pin
Nov 2, 2026
Merged

jdwyah merged 1 commit into
mainfrom
qfg-ao5h4-go-verify-pin

Conversation

@jdwyah

@jdwyah jdwyah commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Why

verify-sdk-boot/boot_check_go and verify-dev-injection/inject_check_go required github.com/quonfig/sdk-go v0.0.0 with replace => ../../../sdk-go, which is outside the repo. That caused three problems:

What

  • go.mod / main.go: require and import github.com/quonfig/sdk-go/v2 v2.1.0, with no replace. x/sys is 0.44.0 in both.
  • run.sh: the new run_go_check builds against the sibling ../../../sdk-go through a temporary go.work. It fails loudly if sdk-go/v2 resolves from anywhere else, such as a sibling on an old pre-v2 branch.
  • dependabot.yml: drop the sdk-go ignore. Bumping the pin is harmless.
  • READMEs updated. No YAML test definitions changed.

Verified

  • go build and govulncheck ./... now load both modules (no called vulns; the only findings are uncalled stdlib advisories for the local toolchain).
  • With a scratch root whose sdk-go is a worktree at origin/main, the sdk-go checks in both verify-dev-injection/run.sh and verify-sdk-boot/run.sh print OK sdk-go against the local checkout.
  • With the real sibling on an old pre-v2 branch, run.sh now prints FAIL sdk-go: resolved sdk-go/v2 from …/pkg/mod/…@v2.1.0, not …/sdk-go instead of silently testing the published release.

🤖 Generated with Claude Code

Both modules required github.com/quonfig/sdk-go v0.0.0 with a replace to
../../../sdk-go, outside the repo. Nothing outside the monorepo could resolve
them: govulncheck's call analysis failed in ssdlc / deps (osv-scanner now
exits 127 on it, failing every ITD PR), and GitHub's dependency graph never
indexed them. sdk-go is also /v2 now, so the replace no longer even matched
the sibling checkout.

go.mod now pins sdk-go/v2 v2.1.0 (x/sys 0.44.0 in both). run.sh builds
against the sibling checkout through a temporary go.work, and fails loudly if
sdk-go/v2 resolves anywhere but ../../../sdk-go. The Dependabot ignore for
sdk-go goes, since bumping the pin is harmless.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

SSDLC sanity check: PASS

No issues found.

Model: claude-sonnet-5-5 (effort medium), commit 641f952, prompt default. Only BLOCK fails this check. To override a BLOCK after reading it, a human adds ssdlc-approved (sanity check only, this commit only) or, in an emergency, hotfix (all checks, needs a justification and follow-up bead).

@jdwyah
jdwyah merged commit 46abefa into main Nov 2, 2026
4 checks passed
@jdwyah
jdwyah deleted the qfg-ao5h4-go-verify-pin branch November 2, 2026 14:03
jdwyah added a commit that referenced this pull request Nov 2, 2026
* origin/main:
  deps: pin published sdk-go/v2 in the Go verify modules (qfg-ao5h4) (#37)
jdwyah added a commit that referenced this pull request Nov 2, 2026
* origin/main:
  deps: pin published sdk-go/v2 in the Go verify modules (qfg-ao5h4) (#37)
jdwyah added a commit that referenced this pull request Nov 2, 2026
* origin/main:
  deps: pin published sdk-go/v2 in the Go verify modules (qfg-ao5h4) (#37)
jdwyah added a commit that referenced this pull request Nov 2, 2026
* origin/main:
  deps: pin published sdk-go/v2 in the Go verify modules (qfg-ao5h4) (#37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant