Repository navigation
deps: pin published sdk-go/v2 in the Go verify modules (qfg-ao5h4) - #37
Merged
Merged
Conversation
Both modules required github.com/quonfig/sdk-go v0.0.0 with a replace to ../../../sdk-go, outside the repo. Nothing outside the monorepo could resolve them: govulncheck's call analysis failed in ssdlc / deps (osv-scanner now exits 127 on it, failing every ITD PR), and GitHub's dependency graph never indexed them. sdk-go is also /v2 now, so the replace no longer even matched the sibling checkout. go.mod now pins sdk-go/v2 v2.1.0 (x/sys 0.44.0 in both). run.sh builds against the sibling checkout through a temporary go.work, and fails loudly if sdk-go/v2 resolves anywhere but ../../../sdk-go. The Dependabot ignore for sdk-go goes, since bumping the pin is harmless. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SSDLC sanity check:
|
jdwyah
added a commit
that referenced
this pull request
Nov 2, 2026
* origin/main: deps: pin published sdk-go/v2 in the Go verify modules (qfg-ao5h4) (#37)
jdwyah
added a commit
that referenced
this pull request
Nov 2, 2026
* origin/main: deps: pin published sdk-go/v2 in the Go verify modules (qfg-ao5h4) (#37)
jdwyah
added a commit
that referenced
this pull request
Nov 2, 2026
* origin/main: deps: pin published sdk-go/v2 in the Go verify modules (qfg-ao5h4) (#37)
jdwyah
added a commit
that referenced
this pull request
Nov 2, 2026
* origin/main: deps: pin published sdk-go/v2 in the Go verify modules (qfg-ao5h4) (#37)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
verify-sdk-boot/boot_check_goandverify-dev-injection/inject_check_gorequiredgithub.com/quonfig/sdk-go v0.0.0withreplace => ../../../sdk-go, which is outside the repo. That caused three problems:ssdlc / depsfails on every open ITD PR (chore(dev-deps): bump @types/node from 22.19.18 to 26.6.5 in /chaos/validator #29-deps: bump js-yaml from 4.3.2 to 5.5.0 in /generators #34). osv-scanner's govulncheck call analysis can't load the packages (replacement directory ../../../sdk-go does not exist), and since chore(dev-deps): bump the npm-minor-patch group across 2 directories with 1 update #28 osv-scanner exits 127 on that instead of continuing.github.com/quonfig/sdk-go/v2, so the replace no longer matched the sibling checkout's module path either.What
go.mod/main.go: require and importgithub.com/quonfig/sdk-go/v2 v2.1.0, with no replace.x/sysis 0.44.0 in both.run.sh: the newrun_go_checkbuilds against the sibling../../../sdk-gothrough a temporarygo.work. It fails loudly ifsdk-go/v2resolves from anywhere else, such as a sibling on an old pre-v2 branch.dependabot.yml: drop the sdk-go ignore. Bumping the pin is harmless.Verified
go buildandgovulncheck ./...now load both modules (no called vulns; the only findings are uncalled stdlib advisories for the local toolchain).sdk-gois a worktree atorigin/main, the sdk-go checks in bothverify-dev-injection/run.shandverify-sdk-boot/run.shprintOK sdk-goagainst the local checkout.run.shnow printsFAIL sdk-go: resolved sdk-go/v2 from …/pkg/mod/…@v2.1.0, not …/sdk-goinstead of silently testing the published release.🤖 Generated with Claude Code