Fix Bezel fallback after interface load failure - #3120
Merged
Merged
Conversation
Contributor
Author
|
Context from my Tahoe/macOS 26.5 setup:
This PR only fixes the broken fallback key. It does not claim to solve the separate file-descriptor-limit problem directly. |
Member
|
Great catch, thanks! This seems like the kind of bug that a stronger type system (or perhaps a language that makes its type system easier to leverage to "make invalid states unrepresentable") would help catch. My kingdom for a Rust (or maybe even Swift) rewrite of QS's core! |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a typo in the command-interface fallback path.
When the preferred command interface cannot be loaded, Quicksilver shows a notification saying it is switching to Bezel. The fallback code then asks the registry for
QSBezelnterfaceController, which is missing theIinInterface.That typo means the intended Bezel fallback can fail, leaving Quicksilver without a usable command interface after an interface/plugin load failure.
This changes the fallback key to
QSBezelInterfaceController.Context: