Clp is now autocloseable, since finalize is deprecated and performanc…#19
Open
snurkabill wants to merge 1 commit intoquantego:developfrom
Open
Clp is now autocloseable, since finalize is deprecated and performanc…#19snurkabill wants to merge 1 commit intoquantego:developfrom
snurkabill wants to merge 1 commit intoquantego:developfrom
Conversation
…e bottleneck. Keeping finalize as fallback option.
mmadoo
added a commit
to DCbrainOrg/clp-java
that referenced
this pull request
May 18, 2022
…recated and performanc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e bottleneck. Keeping finalize as a fallback option.
When spamming many CLP models, the JVM finalizer thread is not able to catch up. Finalize method is considered deprecated and has no guarantees. Leading to memory leaks during computation.
AutoCloseable option provides an explicit method to free native memory. The finalizer thread has little to do and hence no memory leaks occur during computation.
Finalize method should be removed in future releases, forcing a user to explicitly release native memory or use try-wtih-resources block.