feat(github): board-GraphQL partial-data tolerance (TASK-319)#3610
Merged
Conversation
…SK-319) - Add PartialGraphQLError typed error and isTolerable() classifier (NOT_FOUND, FORBIDDEN) - Add ExecuteGraphQLTolerant: unmarshals Data alongside tolerable errors; any non-tolerable or mixed tolerable+fatal response is fatal; no change to ExecuteGraphQL callers - Refactor ExecuteGraphQL to share a private executeGraphQLCore (tolerant=false) - Switch FindIssuesFromProject to ExecuteGraphQLTolerant: logs dropped-node count on partial pages, retains good nodes, continues pagination; fatal errors still abort - Tests: partial/fatal/mixed/strict-unchanged in client_test.go; partial board page + pagination continuation + fatal-aborts in project_source_test.go
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecuteGraphQLToleranttoclient.go— an opt-in variant that classifiesNOT_FOUND/FORBIDDENas tolerable per-node errors, unmarshalsDataalongside a typed*PartialGraphQLError, and treats every other error type (incl.RATE_LIMITED, emptyType) as fatal.ExecuteGraphQLis unchanged (delegates to a sharedexecuteGraphQLCorewithtolerant=false).FindIssuesFromProjectinproject_source.gotoExecuteGraphQLTolerant: logs dropped-node count on partial pages, retains good nodes, and continues pagination — only fatal errors abort.Test plan
TestExecuteGraphQLTolerant: partial (FORBIDDEN/NOT_FOUND) →*PartialGraphQLError+ data populated; fatal (RATE_LIMITED, empty Type) → fatal error; mixed tolerable+fatal → fatal; no errors → nilTestExecuteGraphQL_StrictUnchanged: FORBIDDEN/NOT_FOUND still fatal in strict modeTestFindIssuesFromProject_PartialPage: good nodes retained, pagination continues across second pageTestFindIssuesFromProject_PartialNotFound: NOT_FOUND variantTestFindIssuesFromProject_FatalErrorAborts: RATE_LIMITED aborts and propagates errormake lintclean,make test-shortgreen