Skip to content

chore: mmh3.hash(token, signed=False) instead of abs() #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anush008 wants to merge 2 commits into from
Closed

chore: mmh3.hash(token, signed=False) instead of abs() #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcc0fa7
chore: mmh3.hash(token, signed=False) instead of abs()
anush008 Jul 6, 2024
062fb2c
chore: Updated bm25.py
anush008 Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastembed/sparse/bm25.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def _term_frequency(self, tokens: List[str]) -> Dict[int, float]:

@classmethod
def compute_token_id(cls, token: str) -> int:
return abs(mmh3.hash(token))
return mmh3.hash(token, signed=False)

def query_embed(self, query: Union[str, Iterable[str]], **kwargs) -> Iterable[SparseEmbedding]:
"""To emulate BM25 behaviour, we don't need to use weights in the query, and
Expand Down
4 changes: 2 additions & 2 deletions fastembed/sparse/bm42.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def _rescore_vector(self, vector: Dict[str, float]) -> Dict[int, float]:
new_vector = {}

for token, value in vector.items():
token_id = abs(mmh3.hash(token))
token_id = mmh3.hash(token, signed=False)
# Examples:
# Num 0: Log(1/1 + 1) = 0.6931471805599453
# Num 1: Log(1/2 + 1) = 0.4054651081081644
Expand Down Expand Up @@ -260,7 +260,7 @@ def embed(
def _query_rehash(cls, tokens: Iterable[str]) -> Dict[int, float]:
result = {}
for token in tokens:
token_id = abs(mmh3.hash(token))
token_id = mmh3.hash(token, signed=False)
result[token_id] = 1.0
return result

Expand Down