Skip to content

Update Sen2/MSI L2A to work properly with composites#3355

Open
simonrp84 wants to merge 1 commit intopytroll:mainfrom
simonrp84:s2_msi_l2_comp
Open

Update Sen2/MSI L2A to work properly with composites#3355
simonrp84 wants to merge 1 commit intopytroll:mainfrom
simonrp84:s2_msi_l2_comp

Conversation

@simonrp84
Copy link
Copy Markdown
Member

The Sentinel-2 / MSI reader for L2A files does not support any composites as it uses a non-existent reader name.

This PR adds some L2 composites. It uses a separate YAML to the L1 composites, as the L2 composites do not need to have the atmospheric correction (Rayleigh + path length) applied.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.34%. Comparing base (4e9b8ba) to head (0b346e1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3355   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         466      466           
  Lines       59131    59131           
=======================================
  Hits        56971    56971           
  Misses       2160     2160           
Flag Coverage Δ
behaviourtests 3.58% <ø> (ø)
unittests 96.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you mean when you said "as it uses a non-existent reader name"? The reader name shouldn't matter for finding composites, but the sensor name does. The changes here don't really match what we usually do in Satpy.

  1. The sensor name at the top of the composite config should match the sensor named used in the composite filename and the sensor the reader returns.
  2. Typically to handle some products needing or not needing rayleigh and sunz correction we include the "modifiers" as part of the reader. See the VIIRS SDR reader as an example that includes sunz.
  3. The satellite included in the sensor name is not crazy if the sensor is actually different enough than the sensor on other satellites, but I don't think that's the case here. The "l2" being included has never been done before as far as I know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants