Update Sen2/MSI L2A to work properly with composites#3355
Open
simonrp84 wants to merge 1 commit intopytroll:mainfrom
Open
Update Sen2/MSI L2A to work properly with composites#3355simonrp84 wants to merge 1 commit intopytroll:mainfrom
simonrp84 wants to merge 1 commit intopytroll:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3355 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 466 466
Lines 59131 59131
=======================================
Hits 56971 56971
Misses 2160 2160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djhoese
reviewed
Mar 26, 2026
Member
There was a problem hiding this comment.
What did you mean when you said "as it uses a non-existent reader name"? The reader name shouldn't matter for finding composites, but the sensor name does. The changes here don't really match what we usually do in Satpy.
- The sensor name at the top of the composite config should match the sensor named used in the composite filename and the sensor the reader returns.
- Typically to handle some products needing or not needing rayleigh and sunz correction we include the "modifiers" as part of the reader. See the VIIRS SDR reader as an example that includes sunz.
- The satellite included in the sensor name is not crazy if the sensor is actually different enough than the sensor on other satellites, but I don't think that's the case here. The "l2" being included has never been done before as far as I know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sentinel-2 / MSI reader for L2A files does not support any composites as it uses a non-existent reader name.
This PR adds some L2 composites. It uses a separate YAML to the L1 composites, as the L2 composites do not need to have the atmospheric correction (Rayleigh + path length) applied.