Repository navigation
[Refactor] Fix the unittest setup scripts for OSDC containers - #4531
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4531
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (8 Unrelated Failures)As of commit 034fd2c with merge base 648f50c ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
added this pull request to stack #4533
October 8, 2026 02:25
This was referenced Oct 8, 2026
Three container differences that only show up once the job runs inside the image rather than beside it on an EC2 host. 1. /usr/share/glvnd/egl_vendor.d is a read-only mount under the NVIDIA container runtime, so installing the EGL vendor config there dies with "Read-only file system". libglvnd searches <sysconfdir>/glvnd/egl_vendor.d first (src/EGL/meson.build), so install to /etc/glvnd/egl_vendor.d and skip when the runtime already supplied the file. Six scripts. 2. libgl1-mesa-glx and freeglut3 are gone on noble, which the 12.8 image is. libgl1 + libglx-mesa0 is what the former became and freeglut3-dev pulls the runtime; all resolve on jammy too, verified with apt-get install -s on both. 3. Nothing puts the container's hostname in its /etc/hosts, so socket.gethostbyname(socket.gethostname()) raises gaierror. torchrl's distributed transport uses it to pick the dist.TCPStore address. A plain `docker run` added the entry, which is why this is new off EC2. Authored with Claude Code. ghstack-source-id: 06ac495 Pull-Request: #4528
huydhn
removed this pull request from stack #4533
October 8, 2026 02:30
huydhn
force-pushed
the
osdc/setup-scripts
branch
from
October 8, 2026 02:31
ff57e7b to
034fd2c
Compare
huydhn
added this pull request to stack #4534
October 8, 2026 02:31
Contributor
Author
|
@pytorchbot drci |
huydhn
marked this pull request as ready for review
October 8, 2026 19:03
atalman
approved these changes
Oct 8, 2026
bsprenger
pushed a commit
that referenced
this pull request
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of three. Three container differences that only appear once the job runs inside the image rather than beside it on an EC2 host. All are backward-compatible, so this lands safely before anything moves fleet.
/usr/share/glvnd/egl_vendor.dis a read-only mount under the NVIDIA container runtime. libglvnd searches<sysconfdir>/glvnd/egl_vendor.dfirst, so install there and skip when the runtime already supplied the file. Six scripts.libgl1-mesa-glxandfreeglut3are gone on noble.libgl1 libglx-mesa0andfreeglut3-devreplace them and resolve on jammy too (verified withapt-get install -son both)./etc/hosts, sosocket.gethostbyname(socket.gethostname())raisesgaierror. torchrl's distributed transport uses it to pick thedist.TCPStoreaddress.Stacked below #4532 and #4530.
Authored with Claude Code.