Skip to content

[Refactor] Fix the unittest setup scripts for OSDC containers - #4531

Merged
huydhn merged 1 commit into
mainfrom
osdc/setup-scripts
Oct 9, 2026
Merged

huydhn merged 1 commit into
mainfrom
osdc/setup-scripts

Conversation

@huydhn

@huydhn huydhn commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

First of three. Three container differences that only appear once the job runs inside the image rather than beside it on an EC2 host. All are backward-compatible, so this lands safely before anything moves fleet.

  • /usr/share/glvnd/egl_vendor.d is a read-only mount under the NVIDIA container runtime. libglvnd searches <sysconfdir>/glvnd/egl_vendor.d first, so install there and skip when the runtime already supplied the file. Six scripts.
  • libgl1-mesa-glx and freeglut3 are gone on noble. libgl1 libglx-mesa0 and freeglut3-dev replace them and resolve on jammy too (verified with apt-get install -s on both).
  • Nothing puts the container hostname in its /etc/hosts, so socket.gethostbyname(socket.gethostname()) raises gaierror. torchrl's distributed transport uses it to pick the dist.TCPStore address.

Stacked below #4532 and #4530.

Authored with Claude Code.

@pytorch-bot

pytorch-bot Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4531

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit 034fd2c with merge base 648f50c (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn
huydhn added this pull request to stack #4533 October 8, 2026 02:25
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2026
@github-actions github-actions Bot added Refactoring Refactoring of an existing feature CI Has to do with CI setup (e.g. wheels & builds, tests...) and removed Refactoring Refactoring of an existing feature labels Oct 8, 2026
Three container differences that only show up once the job runs inside the
image rather than beside it on an EC2 host.

1. /usr/share/glvnd/egl_vendor.d is a read-only mount under the NVIDIA
   container runtime, so installing the EGL vendor config there dies with
   "Read-only file system". libglvnd searches <sysconfdir>/glvnd/egl_vendor.d
   first (src/EGL/meson.build), so install to /etc/glvnd/egl_vendor.d and skip
   when the runtime already supplied the file. Six scripts.

2. libgl1-mesa-glx and freeglut3 are gone on noble, which the 12.8 image is.
   libgl1 + libglx-mesa0 is what the former became and freeglut3-dev pulls the
   runtime; all resolve on jammy too, verified with apt-get install -s on both.

3. Nothing puts the container's hostname in its /etc/hosts, so
   socket.gethostbyname(socket.gethostname()) raises gaierror. torchrl's
   distributed transport uses it to pick the dist.TCPStore address. A plain
   `docker run` added the entry, which is why this is new off EC2.

Authored with Claude Code.


ghstack-source-id: 06ac495
Pull-Request: #4528
@huydhn
huydhn removed this pull request from stack #4533 October 8, 2026 02:30
@huydhn
huydhn force-pushed the osdc/setup-scripts branch from ff57e7b to 034fd2c Compare October 8, 2026 02:31
@huydhn
huydhn changed the base branch from osdc/runners to main October 8, 2026 02:31
@huydhn
huydhn added this pull request to stack #4534 October 8, 2026 02:31
@github-actions github-actions Bot added the Refactoring Refactoring of an existing feature label Oct 8, 2026
@huydhn

huydhn commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

@pytorchbot drci

@huydhn
huydhn requested a review from atalman October 8, 2026 18:45
@huydhn
huydhn marked this pull request as ready for review October 8, 2026 19:03
@huydhn
huydhn merged commit 3231aea into main Oct 9, 2026
194 of 216 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants