Skip to content

[BugFix] Restore free-threaded (cp314t) wheel builds - #4522

Draft
kostasrigatos wants to merge 2 commits into
pytorch:mainfrom
kostasrigatos:fix/restore-free-threaded-wheels
Draft

kostasrigatos wants to merge 2 commits into
pytorch:mainfrom
kostasrigatos:fix/restore-free-threaded-wheels

Conversation

@kostasrigatos

Copy link
Copy Markdown

Description

Addresses #4499 (see note on cp313t below).

I checked generate_binary_build_matrix.py. There's no special setting for free-threaded builds — the system detects them only if a Python version string has a t suffix, e.g. 3.14t. PR #3799 replaced this list with a hard-coded version and removed all t-versions, with no explanation. This broke the free-threaded builds.

Motivation and Context

Issue with Python 3.13t: The docker image of PyTorch's manylinux2_28-builder:cpu includes cp314t and cp315t, but not cp313t. I checked directly via docker pull and ls /opt/python/. 3.13t cannot be fixed by editing workflow files, because the required Python version is missing from the build image.

Fix: I added 3.14t back to the python-versions list. This applies to all build-wheels-*.yml workflows, namely Linux, aarch64, M1, and Windows. I did not add 3.13t, since its addition would just cause the build to fail.

Testing: confirmed via workflow_dispatch on this branch that generate-matrix correctly expands 3.14t into a real matrix entry (build-manywheel-py3_14t-cpu). I wasn't able to verify the actual wheel build completes — build_wheels_linux.yml targets PyTorch's self-hosted runner pool, which isn't reachable from a fork — so this needs CI on the PR itself to confirm.

AI disclosure: I used Claude for design discussion, code review, debugging guidance, and drafting this PR description. All code was written by me; nothing in this PR was generated by an agent. I've read, run, and understood every change myself.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTING guide
  • My change requires a change to the documentation.
  • I have updated the tests accordingly
  • I have updated the documentation accordingly.

@pytorch-bot

pytorch-bot Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4522

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 16 Awaiting Approval

As of commit 3f99224 with merge base 7040ad0 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2026
@github-actions github-actions Bot added CI Has to do with CI setup (e.g. wheels & builds, tests...) BugFix labels Oct 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugFix CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant