Repository navigation
[BugFix] Restore free-threaded (cp314t) wheel builds - #4522
Draft
kostasrigatos wants to merge 2 commits into
Draft
kostasrigatos wants to merge 2 commits into
kostasrigatos wants to merge 2 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4522
Note: Links to docs will display an error until the docs builds have been completed.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #4499 (see note on cp313t below).
I checked
generate_binary_build_matrix.py. There's no special setting for free-threaded builds — the system detects them only if a Python version string has atsuffix, e.g.3.14t. PR #3799 replaced this list with a hard-coded version and removed allt-versions, with no explanation. This broke the free-threaded builds.Motivation and Context
Issue with Python 3.13t: The docker image of PyTorch's
manylinux2_28-builder:cpuincludescp314tandcp315t, but notcp313t. I checked directly viadocker pullandls /opt/python/.3.13tcannot be fixed by editing workflow files, because the required Python version is missing from the build image.Fix: I added
3.14tback to thepython-versionslist. This applies to allbuild-wheels-*.ymlworkflows, namely Linux, aarch64, M1, and Windows. I did not add3.13t, since its addition would just cause the build to fail.Testing: confirmed via
workflow_dispatchon this branch thatgenerate-matrixcorrectly expands3.14tinto a real matrix entry (build-manywheel-py3_14t-cpu). I wasn't able to verify the actual wheel build completes —build_wheels_linux.ymltargets PyTorch's self-hosted runner pool, which isn't reachable from a fork — so this needs CI on the PR itself to confirm.AI disclosure: I used Claude for design discussion, code review, debugging guidance, and drafting this PR description. All code was written by me; nothing in this PR was generated by an agent. I've read, run, and understood every change myself.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!