Skip to content

[BugFix] Document AtariDQN dataset unavailability - #4479

Open
YeonwooSung wants to merge 3 commits into
pytorch:mainfrom
YeonwooSung:bugfix/3113-atari-dqn-access-denied
Open

YeonwooSung wants to merge 3 commits into
pytorch:mainfrom
YeonwooSung:bugfix/3113-atari-dqn-access-denied

Conversation

@YeonwooSung

Copy link
Copy Markdown
Contributor

Description

The public GCS source for AtariDQNExperienceReplay (gs://atari-replay-datasets/dqn/...) has been removed. vmoens confirmed this on #3113; gsutil now fails with AccessDenied, while the class docstring still presented download as the happy path.

  • Document that the hosted dataset is gone. Examples that would download are marked # doctest: +SKIP and take a local copy under root.
  • On AccessDenied / gsutil failure, raise a RuntimeError that the hosted dataset was removed and that root= should point at a local copy. Do not surface a raw AccessDenied as the user-facing error.
  • Skip live download tests in test/libs/test_datasets.py (reason points at [BUG] AtariDQNExperienceReplay shows AccessDeniedException #3113). Add offline tests for the AccessDenied error path (mocked gsutil, no network) and for constructing from data already on disk.

The class stays importable. Existing local copies under root still load.

Code example

from torchrl.data.datasets import AtariDQNExperienceReplay

# A missing local copy no longer yields a raw GCS AccessDenied.
try:
    AtariDQNExperienceReplay("Pong/5", batch_size=4, root="/tmp/atari", download=True)
except RuntimeError as err:
    assert "no longer available" in str(err)
    assert "root=" in str(err)

# A previously downloaded copy under root still loads.
dataset = AtariDQNExperienceReplay(
    "Pong/5", batch_size=128, root="/path/to/atari", download=False
)

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

close #3113

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@pytorch-bot

pytorch-bot Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4479

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 2 Unrelated Failures

As of commit e4c2d46 with merge base 84d4602 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions Bot added BugFix Environments Adds or modifies an environment wrapper Data Data-related PR, will launch data-related jobs labels Sep 22, 2026
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugFix CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Data Data-related PR, will launch data-related jobs Environments Adds or modifies an environment wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] AtariDQNExperienceReplay shows AccessDeniedException

2 participants