Repository navigation
[Doc] Document LSTM is_init after slice sampling - #4474
Open
YeonwooSung wants to merge 2 commits into
Open
YeonwooSung wants to merge 2 commits into
YeonwooSung wants to merge 2 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4474
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below:
|
Contributor
|
Hi @YeonwooSung thanks for picking up this request! The docs are quite helpful. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Document the
is_initcontract after slice sampling, and add a CPU regression that hidden state leaks across concatenated mid-episode slices when that contract is skipped.InitTrackeronly marks episode starts. ASliceSamplerwindow can start mid-episode, so every storedis_initflag in that window isFalse. Concatenating those slices looks like one long trajectory toLSTMModule: hidden state from the last step of slice A is fed into the first step of unrelated slice B.The contract: after slice sampling, mark the first timestep of each slice as
is_init=True.SliceSampleralready does this by default (init_key="is_init"). Hand-built batches can OR the first timestep of each slice, or shift("next", "truncated")ontois_init(do not ORtruncatedin place; it sits at slice ends). Sequential mode then zeros the incoming hidden withtorch.where(is_init, zeros, hidden); recurrent mode splits onis_initand restarts from the stored hidden at each split.No LSTM internals are changed.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213close #3147
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!