Skip to content

[Feature] Add TD-MPC2 optimization stepper - #4456

Merged
bsprenger merged 1 commit into
pytorch:mainfrom
bsprenger:feat/tdmpc2-optimization-stepper
Oct 5, 2026
Merged

bsprenger merged 1 commit into
pytorch:mainfrom
bsprenger:feat/tdmpc2-optimization-stepper

Conversation

@bsprenger

@bsprenger bsprenger commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Note

This PR stacks on #4455 . I cannot find a good way to compare the diff against that base, since it is in my own fork.
Once it is merged, I will re-target this one to make the diff easier to read.

This PR introduces the core optimization orchestrator (the optimization stepper) for the TD-MPC2 algorithm.

The optimization stepper is responsible for the key loss evaluation and parameter updates in the trainer framework. The optimization stepper for TD-MPC2 in particular has several key components for the world model and the actor prior, with separate optimizers.

Motivation and Context

7th PR in the chain towards closing #4448. The optimization procedure is described in depth in the original paper and associated implementation.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • New feature (non-breaking change which adds core functionality)

Checklist

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@pytorch-bot

pytorch-bot Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4456

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit e189412 with merge base 65162f2 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 21, 2026
@github-actions github-actions Bot added Feature New feature Documentation Improvements or additions to documentation Modules Trainers and removed Feature New feature labels Sep 21, 2026
@bsprenger
bsprenger force-pushed the feat/tdmpc2-optimization-stepper branch 3 times, most recently from 1b86c3b to a163e48 Compare September 22, 2026 06:09
@bsprenger
bsprenger force-pushed the feat/tdmpc2-optimization-stepper branch 3 times, most recently from bfdf3be to e0459ba Compare September 22, 2026 07:42
@bsprenger
bsprenger force-pushed the feat/tdmpc2-optimization-stepper branch from e0459ba to e189412 Compare October 5, 2026 08:17
@bsprenger
bsprenger merged commit 1441844 into pytorch:main Oct 5, 2026
116 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Documentation Improvements or additions to documentation Feature New feature Integrations/torch_geometric Integrations Modules Objectives Trainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants