Repository navigation
[Feature] Add TD-MPC2 optimization stepper - #4456
Merged
bsprenger merged 1 commit intoOct 5, 2026
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4456
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (8 Unrelated Failures)As of commit e189412 with merge base 65162f2 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 21, 2026
vmoens
approved these changes
Sep 21, 2026
bsprenger
force-pushed
the
feat/tdmpc2-optimization-stepper
branch
3 times, most recently
from
September 22, 2026 06:09
1b86c3b to
a163e48
Compare
bsprenger
force-pushed
the
feat/tdmpc2-optimization-stepper
branch
3 times, most recently
from
September 22, 2026 07:42
bfdf3be to
e0459ba
Compare
bsprenger
force-pushed
the
feat/tdmpc2-optimization-stepper
branch
from
October 5, 2026 08:17
e0459ba to
e189412
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
This PR stacks on #4455 . I cannot find a good way to compare the diff against that base, since it is in my own fork.
Once it is merged, I will re-target this one to make the diff easier to read.
This PR introduces the core optimization orchestrator (the optimization stepper) for the TD-MPC2 algorithm.
The optimization stepper is responsible for the key loss evaluation and parameter updates in the trainer framework. The optimization stepper for TD-MPC2 in particular has several key components for the world model and the actor prior, with separate optimizers.
Motivation and Context
7th PR in the chain towards closing #4448. The optimization procedure is described in depth in the original paper and associated implementation.
Types of changes
Checklist