Repository navigation
[Feature] Add TD-MPC2 Q-network ensemble - #4453
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4453
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit d6e7f5e with merge base 71a4143 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| num_bins: Number of categorical bins. ``0`` uses an identity output and | ||
| ``1`` uses a symmetric exponential output. |
There was a problem hiding this comment.
Advertised num_bins modes are rejected.
The Q-ensemble documentation says 0 provides identity regression and 1 provides symlog regression, but the constructor rejects both. The config factories and loss also only support categorical mode.
Either implement the documented/reference behavior or explicitly narrow the API and documentation to num_bins > 1.
There was a problem hiding this comment.
I updated the documented behaviour. Thanks!
cc85d9a to
1cdfd84
Compare
cafff05 to
620080e
Compare
620080e to
d6e7f5e
Compare
|
@theap06 I've rebased this one after merging its base branch, looking for a re-review / CI, thanks! |
Description
Note
This PR stacks on #4452 . I cannot find a good way to compare the diff against that base, since it is in my own fork.
Once it is merged, I will re-target this one to make the diff easier to read.
This PR introduces the TD-MPC2 Q ensemble, which is a key part of the algorithm. The Q-ensemble consists of$N$ parallel Q-functions to compute TD targets during training of the model and to be used during the planning stage of the algorithm.
Motivation and Context
This is the 4th PR in the chain intended to address #4448 . The Q-ensemble is described in depth in the original paper and associated implementation.
Types of changes
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!