[quinnarnold]

Description

Strengthen the behavioral regression tests identified in #4144:

• verify finite RLHF dataloaders exhaust and infinite dataloaders continue beyond one full pass
• verify zero input covariance produces near-zero action covariance in RBFController

Motivation and Context

The previous tests only consumed one dataloader batch and repeated a deterministic mean assertion, so they did not exercise the intended finite/infinite behavior or covariance propagation.

Closes #4144

• I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist

• I have read the CONTRIBUTION guide (required)
• My change requires a change to the documentation.
• I have updated the tests accordingly (required for a bug fix or a new feature).
• I have updated the documentation accordingly.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4145

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3907729 with merge base db04869 ():

NEW FAILURE - The following job has failed:

• Libs Tests on Linux / unittests-gym (3.10, 12.8) / linux-job (gh)
  test/libs/test_gym.py::TestGym::test_gym[True-True-1-HalfCheetah-v4]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[meta-cla]

Hi @quinnarnold!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[vmoens]

LGTM thanks!