Skip to content

[BugFix] Add MultiCategorical support in PettingZoo action masks - #2485

Merged
vmoens merged 3 commits into
pytorch:mainfrom
matteobettini:fix_pettingzoo_mask
Oct 14, 2024
Merged

vmoens merged 3 commits into
pytorch:mainfrom
matteobettini:fix_pettingzoo_mask

Conversation

@matteobettini

@matteobettini matteobettini commented Oct 10, 2024 •

Copy link
Copy Markdown
Contributor

fixes #2472
may benefit from fixing #2486 for full functionality

@pytorch-bot

pytorch-bot Bot commented Oct 10, 2024 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2485

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 8 Unrelated Failures

As of commit ffe9827 with merge base 56cc525 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2024
@matteobettini matteobettini changed the title [BugFix] Add MultiDiscrete support in PettingZoo masks [BugFix] Add MultiCategroical support in PettingZoo action masks Oct 10, 2024
@matteobettini matteobettini changed the title [BugFix] Add MultiCategroical support in PettingZoo action masks [BugFix] Add MultiCategorical support in PettingZoo action masks Oct 10, 2024
@matteobettini
matteobettini marked this pull request as ready for review October 10, 2024 09:18
@vmoens vmoens added the bug Something isn't working label Oct 10, 2024

@vmoens vmoens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens added the Environments Adds or modifies an environment wrapper label Oct 10, 2024
@vmoens
vmoens force-pushed the fix_pettingzoo_mask branch from e62900e to b361a16 Compare October 10, 2024 14:42
@vmoens
vmoens force-pushed the fix_pettingzoo_mask branch from b361a16 to aae13c2 Compare October 11, 2024 15:13
Vincent Moens added 2 commits October 11, 2024 16:14
@vmoens
vmoens merged commit be15cab into pytorch:main Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Support of MultiDiscrete action space in PettingZoo wrapping

3 participants