Skip to content

Android: Add Tensor.ones() and Tensor.zeros() factory methods#15388

Merged
GregoryComer merged 1 commit into
pytorch:mainfrom
shubham0204:15126-java-ones-zeros-tensor-constructors
Nov 14, 2025
Merged

Android: Add Tensor.ones() and Tensor.zeros() factory methods#15388
GregoryComer merged 1 commit into
pytorch:mainfrom
shubham0204:15126-java-ones-zeros-tensor-constructors

Conversation

@shubham0204

@shubham0204 shubham0204 commented Oct 25, 2025 •
edited by pytorch-bot Bot
Loading

Copy link
Copy Markdown
Contributor

Fixes #15125

Release notes: misc

Summary

  • Add implementation and test for a new factory method Tensor.ones() in the android extension

Test plan

The following new JUnit tests were added to verify the behavior of Tensor.ones() in extension/android/executorch_android/src/test/java/org/pytorch/executorch/TensorTest.kt

  • testOnes_DTypeIsFloat

cc @kirklandsign @cbilgin

@pytorch-bot

pytorch-bot Bot commented Oct 25, 2025 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15388

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 6 Pending

As of commit fac5d2e with merge base 964515c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 25, 2025
@shubham0204 shubham0204 marked this pull request as draft October 25, 2025 07:05
@shubham0204

shubham0204 commented Oct 25, 2025

Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: misc"

@pytorch-bot pytorch-bot Bot added the release notes: misc Miscellaneous label Oct 25, 2025
@shubham0204 shubham0204 marked this pull request as ready for review October 25, 2025 08:12
@shubham0204 shubham0204 mentioned this pull request Oct 25, 2025
Closed
@digantdesai digantdesai added the module: android Issues related to Android code, build, and execution label Oct 27, 2025
@digantdesai digantdesai requested review from kirklandsign and removed request for kirklandsign October 27, 2025 19:43
@GregoryComer GregoryComer requested a review from psiddh October 27, 2025 20:31
@GregoryComer

GregoryComer commented Nov 4, 2025

Copy link
Copy Markdown
Member

@shubham0204 Thanks for the contribution. Can you fix the java android lint and rebase the PR? If everything looks good, we can merge it shortly.

@shubham0204

shubham0204 commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@GregoryComer I have fixed the Java formatting issues in the modified files. The formatting used is google-java-format as described suggested in the failing CI job. Also rebased the branch onto pytorch:main.

@shubham0204

shubham0204 commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

@GregoryComer @kirklandsign @psiddh Any updates on this PR?

@GregoryComer

GregoryComer commented Nov 13, 2025

Copy link
Copy Markdown
Member

@shubham0204 Apologies for the slow response. Can you take a look at the errors in this CI job: https://github.com/pytorch/executorch/actions/runs/19102814458/job/54604914604?pr=15388? We should be good to merge once that's green. Thanks!

@shubham0204
Android: Add Tensor.ones() and Tensor.zeros() factory method to creat…
fac5d2e 
…e tensors initialized with ones and zeros resp. (#15125)
@shubham0204

shubham0204 commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@GregoryComer I have fixed the formatting issue that was causing the job to fail. Could you re-run those workflows?

@GregoryComer GregoryComer merged commit f92565f into pytorch:main Nov 14, 2025
134 of 143 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in ExecuTorch Android Nov 14, 2025
@GregoryComer

GregoryComer commented Nov 14, 2025

Copy link
Copy Markdown
Member

CI looks green, so I'll go ahead and merge. Thanks for the contribution!

jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
@shubham0204 @jirioc
Android: Add Tensor.ones() and Tensor.zeros() factory methods (pytorc…
91ba068 
…h#15388)

Fixes pytorch#15125 

Release notes: `misc`

### Summary

- [x] Add implementation and test for a new factory method
`Tensor.ones()` in the `android` extension

### Test plan

The following new JUnit tests were added to verify the behavior of
`Tensor.ones()` in
`extension/android/executorch_android/src/test/java/org/pytorch/executorch/TensorTest.kt`

- `testOnes_DTypeIsFloat`


cc @kirklandsign @cbilgin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

@psiddh psiddh Awaiting requested review from psiddh psiddh is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: android Issues related to Android code, build, and execution release notes: misc Miscellaneous

Projects

ExecuTorch Android
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Zeros/Ones Tensor Constructor (Android)

5 participants

@shubham0204 @GregoryComer @kirklandsign @digantdesai @nil-is-all