Repository navigation
Conversation
Keep XPU skips only for Float8. Report INT8 SQNR while preserving the 16.5 dB threshold.
eryk-roch
requested review from
andrewor14,
jerryzh168 and
vkuzo
as code owners
October 7, 2026 12:35
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4977
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unclassified FailureAs of commit 42f5d62 with merge base cff77b4 ( NEW FAILURE - The following job has failed:
UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
eryk-roch
marked this pull request as draft
October 7, 2026 12:36
liangan1
reviewed
Oct 8, 2026
| y_q = m_q(x) | ||
|
|
||
| sqnr = compute_error(y_ref, y_q) | ||
| print(f"{type(config).__name__}: SQNR={sqnr.item():.4f} dB, device={device}") |
Collaborator
There was a problem hiding this comment.
Don't add the print info in this UT.
liangan1
reviewed
Oct 8, 2026
liangan1
reviewed
Oct 8, 2026
| y_q = m_q(x) | ||
|
|
||
| sqnr = compute_error(y_ref, y_q) | ||
| print(f"{type(config).__name__}: SQNR={sqnr.item():.4f} dB, device={device}") |
Collaborator
There was a problem hiding this comment.
Suggested change
| print(f"{type(config).__name__}: SQNR={sqnr.item():.4f} dB, device={device}") | |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep XPU skips only for Float8. Report INT8 SQNR while preserving the 16.5 dB threshold.