Repository navigation
fix: benchmark_model CPU timing units - #4972
AdudodlaVarish wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4972
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @AdudodlaVarish! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Fix benchmark_model CPU timing units
benchmark_model()returns milliseconds on CUDA, MPS, and XPU, but returns seconds on CPU. This makes CPU results numerically wrong by a factor of 1,000.Convert the CPU elapsed time to milliseconds and document the return unit. Add a deterministic test using a real CPU
Linearmodule and a controlled clock: two runs over a 0.5-second interval must return 250 milliseconds per run, rather than 0.25.Validation on Windows, Python 3.12.14, PyTorch 2.14.1+cpu:
Targeted Ruff lint (
--select F,I) and format checks pass (Ruff 0.16.10), as doesgit diff --check. The full test suite, full pre-commit, and accelerator execution were not run.