Repository navigation
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4967
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @JoshBong! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Machines that do not support Triton (macOS) cannot import Triton, which breaks
make htmlfor anyone building docs locally. The import error was found intorchao.prototype.attentioncausing the build to fail, which I noticed while working on issue #3863.Reproduction
make htmlfails with a misleading error:The real cause, from
python -c "import torchao.prototype.attention.fp8_fa3":Fix
Since all of prototype.attention's triton kernel modules are imported through
quantization/__init__.py, I guarded those imports withhas_triton()(the same pattern asprototype/mx_formats/kernels.py). Without triton, the 5 names point to a placeholder function instead, so the package still imports and the docs build, but actually calling a kernel raises a clear error that triton is required.Disclosure
I used Claude to help trace the import chain, but I reviewed and tested the change myself.