Repository navigation
Fix MaskedLayerNorm with bias=False - #4966
Open
adenzhou1350 wants to merge 1 commit into
Open
adenzhou1350 wants to merge 1 commit into
adenzhou1350 wants to merge 1 commit into
Conversation
Signed-off-by: Xucheng Zhou <aden1350@outlook.com>
adenzhou1350
requested review from
andrewor14,
jerryzh168 and
vkuzo
as code owners
September 30, 2026 22:39
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4966
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaskedLayerNorminheritsnn.LayerNorm'sbias=Falseoption, but its forward always addsself.bias. With affine weights enabled and bias disabled, that isNoneand forward raises aTypeError.Apply the weight as before and only add bias when present. This leaves the existing treatment of zero-valued inputs and default affine behavior unchanged.
Tests cover bias-free forward/backward against
nn.LayerNormon nonzero inputs (float32/float64, one- and two-dimensional normalized shapes), mixed/all-zero inputs, and existing affine options.Validation on Linux, Python 3.12 and PyTorch 2.11.0: normal TorchAO source-package import with C++ extensions disabled and CUDA hidden;
python3 -m pytest test/prototype/pat/test_masked_layernorm.py -qpassed (4 tests, 7 subtests). The same tests fail on main with theTensor + Noneerror. Ruff check/format and diff check pass. No GPU or full-repository CI claim.