Fix exception types in arcade.sound#1926
Merged
eruvanos merged 12 commits intopythonarcade:developmentfrom Nov 29, 2023
Merged
Conversation
* Add value echoing for all types * Only print load_sound recommendation on the most common errors.
eruvanos
requested changes
Nov 8, 2023
Member
eruvanos
left a comment
There was a problem hiding this comment.
Will merge after the small fix
eruvanos
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TypeErrorinstead ofValueErrorwhen the wrong types are passed to sound helpersThe items in 4 are generally well-separated out and easy to revert, and I can understand if reviewers think we should do that.
This is a follow-up to some reading done for #1922.