This repository was archived by the owner on Aug 19, 2024. It is now read-only.
Subscription failure handling#3
Open
penguinpowernz wants to merge 8 commits intopythonandchips:masterfrom
Open
Subscription failure handling#3penguinpowernz wants to merge 8 commits intopythonandchips:masterfrom
penguinpowernz wants to merge 8 commits intopythonandchips:masterfrom
Conversation
And asserted that it was nil
Owner
|
Hi @penguinpowernz thanks for the pull request! I like the returning both the error and the promise nice work as we may have to other errors errors back. I'll give it a quick test the night and merge it in. Cheers Again |
|
any chance to have this merged? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK, made this thing handle subscription failures, even added a test for it 👍 (first time working with GoConvey).
Here's the skinny:
I wasn't sure whether to skip the returning of the error as the second param, but it is a go idiom... so I thought I would leave it there. What say you @pythonandchips ?