Increase pyright strictness when checking __all__#7356
Merged
hauntsaninja merged 20 commits intopython:masterfrom Mar 2, 2022
Merged
Increase pyright strictness when checking __all__#7356hauntsaninja merged 20 commits intopython:masterfrom
__all__#7356hauntsaninja merged 20 commits intopython:masterfrom
Conversation
c61ea74 to
45dfa04
Compare
Merged
This comment has been minimized.
This comment has been minimized.
This was referenced Feb 22, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
Collaborator
|
@AlexWaygood Looking at the source code, Edit: I can create a separate PR if you wish. |
Member
Author
Yes please 🙂 |
Collaborator
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Member
Author
|
I'm going to mark this as "ready for review", as it's nearly mergeable. There are two remaining blockers:
|
Member
Author
Member
Author
|
Aaand CI is finally green! 🥳🥳🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And also fix a typo in
pyrightconfig.stricter.jsonthat was already fixed inpyrightconfig.jsonin #7355