Conversation
deaaccf to
58fb02c
Compare
msullivan
left a comment
There was a problem hiding this comment.
This looks good but I think it doesn't solve the whole issue. This deals with it for types but also I think needs to deal with it for expressions in Python 3.
|
Sorry, I don't understand what you mean with "expressions in Python 3" |
|
Just a thought, I think he means Python 3.5, 3.6 etc (not only 3.9 and up), but I might be wrong as he mentions |
|
Hello! I wrote up my own version of this fix, before I found that this PR existed. I believe Sully's referring to making sure anywhere else we You'll still want CI to pass though, feel free to look at my fix. Also happy to open a PR directly: https://github.com/hauntsaninja/mypy/tree/py39 Separately, some stuff still needs to happen to get CI green for Python 3.9, see https://bugs.python.org/issue40349. We should probably start tracking stuff come beta. |
|
This should be closed, since we merged #8716 |
|
Thanks for your contribution @CyberSaxosTiGER. |
No description provided.